Add gdata content search to file_manager

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * FileManager constructor.
  *
  * FileManager objects encapsulate the functionality of the file selector
  * dialogs, as well as the full screen file manager application (though the
  * latter is not yet implemented).
@@ skipping 960 matching lines @@
       this.commands_[key].disabled = !this.canExecute_(key);
   };
 
   /**
    * @param {string} commandId Command identifier.
    * @return {boolean} True if the command can be executed for current
    *                   selection.
    */
   FileManager.prototype.canExecute_ = function(commandId) {
     var readonly = this.isOnReadonlyDirectory();
+    var shouldCreate = !util.isSpecialReadonlyDirectory(
+                            this.directoryModel_.getCurrentDirEntry().fullPath);
     switch (commandId) {
       case 'copy':
       case 'cut':
         return this.document_.queryCommandEnabled(commandId);
 
       case 'paste':
         return !!this.fileTransferController_ &&
-               this.fileTransferController_.queryPasteCommandEnabled();
+               this.fileTransferController_.queryPasteCommandEnabled() &&
+               shouldCreate;
 
       case 'rename':
         return (// Initialized to the point where we have a current directory
                 !readonly &&
                 // Rename not in progress.
                 !this.isRenamingInProgress() &&
                 // Only one file selected.
                 this.selection &&
                 this.selection.totalCount == 1);
 
       case 'delete':
         return (// Initialized to the point where we have a current directory
                 !readonly &&
                 // Rename not in progress.
                 !this.isRenamingInProgress() &&
                 this.selection &&
                 this.selection.totalCount > 0);
 
       case 'newfolder':
         return !readonly &&
+               shouldCreate &&
                (this.dialogType_ == FileManager.DialogType.SELECT_SAVEAS_FILE ||
                 this.dialogType_ == FileManager.DialogType.FULL_PAGE);
 
       case 'unmount':
         return true;
 
       case 'format':
         var entry = this.directoryModel_.getCurrentRootDirEntry();
 
         return entry && DirectoryModel.getRootType(entry.fullPath) ==
@@ skipping 804 matching lines @@
    * Render filename label for grid and list view.
    * @param {Entry} entry The Entry object to render.
    * @return {HTMLDivElement} The label.
    */
   FileManager.prototype.renderFileNameLabel_ = function(entry) {
     // Filename need to be in a '.filename-label' container for correct
     // work of inplace renaming.
     var fileName = this.document_.createElement('div');
     fileName.className = 'filename-label';
 
+    var displayName =
+        this.directoryModel_.getDisplayName(entry.fullPath, entry.name);
+
     fileName.textContent =
         this.directoryModel_.getCurrentDirEntry().name == '' ?
-            this.getRootLabel_(entry.name) : entry.name;
+            this.getRootLabel_(displayName) : displayName;
     return fileName;
   };
 
   /**
    * Render the Size column of the detail table.
    *
    * @param {Entry} entry The Entry object to render.
    * @param {string} columnId The id of the column to be rendered.
    * @param {cr.ui.Table} table The table doing the rendering.
    */
@@ skipping 1007 matching lines @@
     var path = rootPathNames.join('/') + '/';
     var doc = this.document_;
 
     for (var i = 0; i < pathNames.length; i++) {
       var pathName = pathNames[i];
       path += pathName;
 
       var div = doc.createElement('div');
 
       div.className = 'breadcrumb-path';
-      div.textContent = i == 0 ? this.getRootLabel_(path) : pathName;
+      div.textContent = i == 0 ? this.getRootLabel_(path) :

[SeRya, 2012/05/07 14:06:00]

You are going to show in breadcrumbs path like "gdata > .search > firestkeyword
secondkeyword > directory", right?

If so i think:
1. '.search' looks strangely in breadcrumbs. It should be replaced with a user
friendly string.
2. I think double click to a directory should navigate to the directory in its
original path. Path like ".. > search query > dir1 > dir2" looks confusing.
Please, clarify it with the UX team.
3. Search query in breadcrumbs duplicate contents of the search box. I think it
shouldn't be displayed. Please, clarify it with the UX team.

[tbarzic, 2012/05/10 03:20:47]

With the newest version we will modifying breadcrumbs for search path only in
extreme case when the user types search path in the address bar (the case about
which we shouldn't care to much), so this should probably be good enough to
handle that case. What do you think?

+                                 this.directoryModel_.getDisplayName(path,
+                                                                     pathName);
 
       path = path + '/';
       div.path = path;
 
       bc.appendChild(div);
 
-      if (i == pathNames.length - 1) {
-        div.classList.add('breadcrumb-last');
+      if (i == pathNames.length - 1 ||
+          path == util.GDATA_SEARCH_ROOT_PATH + '/') {
+        div.classList.add('breadcrumb-non-clickable');
       } else {
         div.addEventListener('click', this.onBreadcrumbClick_.bind(this));
+      }
 
+      if (i != pathNames.length - 1) {
         var spacer = doc.createElement('div');
         spacer.className = 'separator';
         bc.appendChild(spacer);
       }
     }
     this.truncateBreadcrumbs_();
   };
 
   FileManager.prototype.isRenamingInProgress = function() {
     return !!this.renameInput_.currentEntry;
@@ skipping 486 matching lines @@
    * Update the UI when the current directory changes.
    *
    * @param {cr.Event} event The directory-changed event.
    */
   FileManager.prototype.onDirectoryChanged_ = function(event) {
     this.updateCommonActionButtons_();
     this.updateOkButton_();
     this.updateBreadcrumbs_();
     this.updateColumnModel_();
 
+   // We don't want to keep a record in browser history for each key press in
+   // the search box.
+   var shouldReplaceHistory =

[SeRya, 2012/05/07 14:06:00]

I think when search query change DirectoryModel musn't fire the directory-change
event at all. It breaks abstraction. Searching and changing current directory
are different events. File Manager shouldn't check free space and do many other
things on pressing a key in the search box.

[tbarzic, 2012/05/10 03:20:47]

Done.

+        event.initial ||
+        (util.isSpecialReadonlyDirectory(event.newDirEntry.fullPath) &&
+         util.isSpecialReadonlyDirectory(event.previousDirEntry.fullPath));
+
     // Sometimes we rescan the same directory (when mounting GData lazily first,
     // then for real). Do not update the location then.
     if (event.newDirEntry.fullPath != event.previousDirEntry.fullPath) {
-      this.updateLocation_(event.initial, event.newDirEntry.fullPath);
+      this.updateLocation_(shouldReplaceHistory, event.newDirEntry.fullPath);
     }
 
     this.checkFreeSpace_(this.getCurrentDirectory());
 
     this.updateTitle_();
 
     if (this.filesystemObserverId_)
       this.metadataCache_.removeObserver(this.filesystemObserverId_);
     if (this.gdataObserverId_)
       this.metadataCache_.removeObserver(this.gdataObserverId_);
@@ skipping 170 matching lines @@
       nameNode.textContent = entry.name;
       this.alert.show(strf('ERROR_RENAMING', entry.name,
                            util.getFileErrorMnemonic(err.code)));
     }
 
     this.cancelRename_();
     // Optimistically apply new name immediately to avoid flickering in
     // case of success.
     nameNode.textContent = newName;
 
-    this.directoryModel_.doesExist(newName, function(exists, isFile) {
+    this.directoryModel_.doesExist(entry, newName, function(exists, isFile) {
       if (!exists) {
         this.directoryModel_.renameEntry(entry, newName, onError.bind(this));
       } else {
-        nameNode.textContent = entry.name;
+        nameNode.textContent =
+            this.directoryModel_.getDisplayName(entry.fullPath, entry.name);
         var message = isFile ? 'FILE_ALREADY_EXISTS' :
                                'DIRECTORY_ALREADY_EXISTS';
         this.alert.show(strf(message, newName));
       }
     }.bind(this));
   };
 
   FileManager.prototype.cancelRename_ = function() {
     this.renameInput_.currentEntry = null;
 
@@ skipping 665 matching lines @@
 
     if (oldValue) {
       event.target.removeAttribute('checked');
     } else {
       event.target.setAttribute('checked', 'checked');
     }
   };
 
   FileManager.prototype.onSearchBoxUpdate_ = function(event) {
     var searchString = this.dialogDom_.querySelector('#search-box').value;
-    if (searchString) {
-      this.directoryModel_.addFilter(
-          'searchbox',
-          function(e) {
-            return e.name.substr(0, searchString.length) == searchString;
-          });
-    } else {
-      this.directoryModel_.removeFilter('searchbox');
-    }
+    this.directoryModel_.search(searchString);
   };
 
   FileManager.prototype.decorateSplitter = function(splitterElement) {
     var self = this;
 
     var Splitter = cr.ui.Splitter;
 
     var customSplitter = cr.ui.define('div');
 
     customSplitter.prototype = {
@@ skipping 113 matching lines @@
 
     this.directoryModel_.addEventListener('scan-completed', maybeShowBanner);
     this.directoryModel_.addEventListener('rescan-completed', maybeShowBanner);
 
     var style = this.document_.createElement('link');
     style.rel = 'stylesheet';
     style.href = 'css/gdrive_welcome.css';
     this.document_.head.appendChild(style);
   };
 })();