Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 10342006: Reland "Error on multiple files with same basenames in static library targets." (Closed)

Created:
8 years, 7 months ago by Nico
Modified:
8 years, 7 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Reland "Error on multiple files with same basenames in static library targets." Disable the check on Android for now. The other platforms should now be fixed. Original review: https://chromiumcodereview.appspot.com/10010028 gyp r1357

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -22 lines) Patch
M pylib/gyp/input.py View 1 4 chunks +47 lines, -16 lines 1 comment Download
A + test/same-name/gyptest-fail.py View 0 chunks +-1 lines, --1 lines 0 comments Download
MM test/same-name/src/all.gyp View 2 chunks +0 lines, -8 lines 0 comments Download
A + test/same-name/src/double.gyp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
8 years, 7 months ago (2012-05-02 23:15:19 UTC) #1
scottmg
lgtm http://chromiumcodereview.appspot.com/10342006/diff/2001/pylib/gyp/input.py File pylib/gyp/input.py (right): http://chromiumcodereview.appspot.com/10342006/diff/2001/pylib/gyp/input.py#newcode2476 pylib/gyp/input.py:2476: if 'arm' not in variables.get('target_arch', ''): windows8 on ...
8 years, 7 months ago (2012-05-02 23:20:43 UTC) #2
Nico
8 years, 7 months ago (2012-05-02 23:22:49 UTC) #3
On 2012/05/02 23:20:43, scottmg wrote:
> lgtm
> 
> http://chromiumcodereview.appspot.com/10342006/diff/2001/pylib/gyp/input.py
> File pylib/gyp/input.py (right):
> 
>
http://chromiumcodereview.appspot.com/10342006/diff/2001/pylib/gyp/input.py#n...
> pylib/gyp/input.py:2476: if 'arm' not in variables.get('target_arch', ''):
> windows8 on arm? ;)

Would likely hit the same issue in we…oh. hm. :-)

Powered by Google App Engine
This is Rietveld 408576698