Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1034002: adding fullscreen support to the mediaplayer (Closed)

Created:
10 years, 9 months ago by dhg
Modified:
9 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

adding fullscreen support to the mediaplayer. Tested by loading on device and clicking fullscreen button. (needs most recent codebase) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42408

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -4 lines) Patch
A chrome/app/theme/mediaplayer_full_screen.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/mediaplayer_ui.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/mediaplayer_ui.cc View 1 4 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/resources/mediaplayer.html View 8 chunks +38 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dhg
10 years, 9 months ago (2010-03-16 22:17:36 UTC) #1
xiyuan
10 years, 9 months ago (2010-03-17 03:08:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698