Re-enable <input type="file"> for platform apps.

chrome/browser/ui/extensions/shell_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/extensions/shell_window.h"
 
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extension_tabs_module_constants.h"
 #include "chrome/browser/extensions/extension_window_controller.h"
 #include "chrome/browser/extensions/shell_window_registry.h"
 #include "chrome/browser/intents/web_intents_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sessions/session_id.h"
+#include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/intents/web_intent_picker_controller.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_view_type.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
@@ skipping 120 matching lines @@
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_Request, OnRequest)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void ShellWindow::CloseContents(WebContents* contents) {
   Close();
 }
 
-// TODO(benwells): Rearrange so users of this can call

[benwells, 2012/05/17 00:46:46]

Turns out some implementers of ShouldSuppressDialogs do more than return true /
false, but use it as a signal that the renderer wants to show a dialog.

-// WebContents::set_should_suppress_dialogs(bool) instead of overriding
-// this delegate function.
 bool ShellWindow::ShouldSuppressDialogs() {
   return true;
 }
 
 void ShellWindow::WebIntentDispatch(
     content::WebContents* web_contents,
     content::WebIntentsDispatcher* intents_dispatcher) {
   if (!web_intents::IsWebIntentsEnabled(profile_))
     return;
 
   contents_wrapper_->web_intent_picker_controller()->SetIntentsDispatcher(
       intents_dispatcher);
   contents_wrapper_->web_intent_picker_controller()->ShowDialog(
       intents_dispatcher->GetIntent().action,
       intents_dispatcher->GetIntent().type);
 }
 
+void ShellWindow::RunFileChooser(WebContents* tab,
+                                 const content::FileChooserParams& params) {
+  Browser::RunFileChooserHelper(tab, params);

[Mihai Parparita -not on Chrome, 2012/05/17 00:51:44]

Huh, Browser seems like an odd place for this helper method.

Scott, can you think of a better place for it?

[benwells, 2012/05/17 01:02:26]

There are a bunch of helpers like this on Browser:
EnumerateDirectoryHelper
JSOutOfMemoryHelper
....

[sky, 2012/05/17 03:57:37]

How about a static method on FileSelectHelper? And just because there are a
bunch of random unrelated methods on Browser doesn't mean we should add more.
Browser sorely needs some love.

+}
+
 void ShellWindow::Observe(int type,
                           const content::NotificationSource& source,
                           const content::NotificationDetails& details) {
   switch (type) {
     case chrome::NOTIFICATION_EXTENSION_UNLOADED: {
       const Extension* unloaded_extension =
           content::Details<UnloadedExtensionInfo>(details)->extension;
       if (extension_ == unloaded_extension)
         Close();
       break;
     }
     case content::NOTIFICATION_APP_TERMINATING:
       Close();
       break;
     default:
       NOTREACHED() << "Received unexpected notification";
   }
 }
 
 ExtensionWindowController* ShellWindow::GetExtensionWindowController() const {
   return extension_window_controller_.get();
 }
 
 void ShellWindow::OnRequest(const ExtensionHostMsg_Request_Params& params) {
   extension_function_dispatcher_.Dispatch(params,
                                           web_contents_->GetRenderViewHost());
 }