chrome/browser/ui/gtk/browser_window_gtk.cc - Issue 10332185: Update behavior of one-click infobar to remove modal dialog, add "undo".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/browser_window_gtk.cc

Issue 10332185: Update behavior of one-click infobar to remove modal dialog, add "undo". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make GTK ok and undo buttons the same size horizontally Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm ('K') | « chrome/browser/ui/gtk/browser_window_gtk.h ('k') | chrome/browser/ui/gtk/one_click_signin_bubble_gtk.h » ('j') | chrome/browser/ui/gtk/one_click_signin_bubble_gtk.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/browser_window_gtk.cc

diff --git a/chrome/browser/ui/gtk/browser_window_gtk.cc b/chrome/browser/ui/gtk/browser_window_gtk.cc

index fba375602edbab7e6b1231f144f9faa9d5a04971..af59db5274a09b2664fb10e567056420beb05e11 100644

--- a/chrome/browser/ui/gtk/browser_window_gtk.cc

+++ b/chrome/browser/ui/gtk/browser_window_gtk.cc

@@ -1090,10 +1090,8 @@ void BrowserWindowGtk::ShowChromeToMobileBubble() {

#if defined(ENABLE_ONE_CLICK_SIGNIN)

void BrowserWindowGtk::ShowOneClickSigninBubble(

- const base::Closure& learn_more_callback,

- const base::Closure& advanced_callback) {

- ignore_result(new OneClickSigninBubbleGtk(this, learn_more_callback,

- advanced_callback));

+ const StartSyncCallback& start_sync_callback) {

+ ignore_result(new OneClickSigninBubbleGtk(this, start_sync_callback));

Peter Kasting 2012/05/24 22:25:18 Nit: Do we need ignore_result() here? new() isn't

Roger Tawa OOO till Jul 10th 2012/05/25 16:04:08 Done.

}

#endif