chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 10332185: Update behavior of one-click infobar to remove modal dialog, add "undo".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 10332185: Update behavior of one-click infobar to remove modal dialog, add "undo". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix mac compiler error Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_window.h ('K') | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index c0bf3ce5b8150748a04cffd439858e217cc67959..34cf67c566e5594a0cbc88957205d1eca4663cc3 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -452,15 +452,12 @@ void BrowserWindowCocoa::ShowChromeToMobileBubble() {

}

#if defined(ENABLE_ONE_CLICK_SIGNIN)

void BrowserWindowCocoa::ShowOneClickSigninBubble(

- const base::Closure& learn_more_callback,

- const base::Closure& advanced_callback) {

+ const base::Callback<void(bool)>& start_sync_callback) {

OneClickSigninBubbleController* bubble_controller =

[[OneClickSigninBubbleController alloc]

initWithBrowserWindowController:cocoa_controller()

- learnMoreCallback:learn_more_callback

- advancedCallback:advanced_callback];

+ start_sync_callback:start_sync_callback];

[bubble_controller showWindow:nil];

}

#endif