Update behavior of one-click infobar to remove modal dialog, add "undo".

chrome/browser/ui/browser_window.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #pragma once
 
 #include "base/callback_forward.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
@@ skipping 32 matching lines @@
 class Rect;
 class Size;
 }
 
 
 enum DevToolsDockSide {
   DEVTOOLS_DOCK_SIDE_BOTTOM = 0,
   DEVTOOLS_DOCK_SIDE_RIGHT = 1
 };
 
+// Callback type used with the ShowOneClickSigninBubble() method of class
+// BrowserWindow.  If the user chooses to accept the sign in, the callback
+// is called.  The boolean argument is true if the default sync settings should
+// be used, and false if the user wants to configure the settings.
+typedef base::Callback<void(bool)> OneClickSigninBubbleCallback;

[akalin, 2012/05/23 21:15:48]

I'm sorry to be a stickler about this, but:

- What happened to the enum? (instead of the bool) ( enum StartSyncMode {
SYNC_WITH_DEFAULT_SETTINGS, CONFIGURE_SYNC_FIRST }; )

- OneClickSigninBubbleCallback isn't very descriptive -- it doesn't tell me what
it actually does, which is to start sync.  Why not my suggested name,
StartSyncCallback?

- The natural place for the enum (and thus the callback) is to me
one_click_signin_sync_starter.h, which this file can include.  Having to pull in
browser_window.h (relatively large) just for StartSyncCallback seems suboptimal
to me.

[Roger Tawa OOO till Jul 10th, 2012/05/24 14:38:59]

Sorry Fred, my bad.  I was going to do the enum but forgot before sending the
review.  As for name of class I'm OK with that.

However, I don't think one_click_signin_sync_starter.h is the right place.  I do
think browser_window.h is the closest header file since the callback is needed
by any class that implements BrowserWindow or calls on BrowserWindow (which are
the various one click bubble implementations for the various platforms).  Its
not used at all by OneClickSigninSyncStarter.  Note that I could also declare
the type inside the class BrowserWindow so as to not pollute the namespace.

If you don't think browser_window.h is the right place, then I think the best
other alternative is to put it in its own header file, much like
base\callback_forward.h, and then include this header where needed.

+
 ////////////////////////////////////////////////////////////////////////////////
 // BrowserWindow interface
 //  An interface implemented by the "view" of the Browser window.
 //  This interface includes BaseWindow methods as well as Browser window
 //  specific methods.
 //
 // NOTE: All getters may return NULL.
 //
 class BrowserWindow : public BaseWindow {
  public:
@@ skipping 151 matching lines @@
   virtual void ShowBackgroundPages() = 0;
 
   // Shows the Bookmark bubble. |url| is the URL being bookmarked,
   // |already_bookmarked| is true if the url is already bookmarked.
   virtual void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) = 0;
 
   // Shows the Chrome To Mobile bubble.
   virtual void ShowChromeToMobileBubble() = 0;
 
 #if defined(ENABLE_ONE_CLICK_SIGNIN)
-  // Shows the one-click sign in bubble.  The given closures are run
-  // when their corresponding links are clicked.
+  // Shows the one-click sign in bubble.  If the user chooses to accept the
+  // sign in, |start_sync_callback| is called.
   virtual void ShowOneClickSigninBubble(
-      const base::Closure& learn_more_callback,
-      const base::Closure& advanced_callback) = 0;
+      const OneClickSigninBubbleCallback& start_sync_callback) = 0;
 #endif
 
   // Whether or not the shelf view is visible.
   virtual bool IsDownloadShelfVisible() const = 0;
 
   // Returns the DownloadShelf.
   virtual DownloadShelf* GetDownloadShelf() = 0;
 
   // Shows the confirmation dialog box warning that the browser is closing with
   // in-progress downloads.
@@ skipping 155 matching lines @@
 
   // Returns the ToolbarView.
   virtual ToolbarView* GetToolbarView() const = 0;
 #endif
 
  protected:
   virtual ~BrowserWindowTesting() {}
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_WINDOW_H_