content/browser/download/save_file_resource_handler.cc - Issue 10332130: Use defer out-params instead of ResourceDispatcherHostImpl::PauseRequest(...true)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_file_resource_handler.cc

Issue 10332130: Use defer out-params instead of ResourceDispatcherHostImpl::PauseRequest(...true) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/download_resource_handler.cc ('K') | « content/browser/download/save_file_resource_handler.h ('k') | content/browser/renderer_host/async_resource_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/save_file_resource_handler.cc

===================================================================

--- content/browser/download/save_file_resource_handler.cc (revision 136397)

+++ content/browser/download/save_file_resource_handler.cc (working copy)

@@ -44,7 +44,8 @@

bool SaveFileResourceHandler::OnResponseStarted(

int request_id,

- content::ResourceResponse* response) {

+ content::ResourceResponse* response,

+ bool* defer) {

save_id_ = save_manager_->GetNextId();

// |save_manager_| consumes (deletes):

SaveFileCreateInfo* info = new SaveFileCreateInfo;

@@ -80,7 +81,8 @@

return true;

}

-bool SaveFileResourceHandler::OnReadCompleted(int request_id, int* bytes_read) {

+bool SaveFileResourceHandler::OnReadCompleted(int request_id, int* bytes_read,

+ bool* defer) {

DCHECK(read_buffer_);

// We are passing ownership of this buffer to the save file manager.

scoped_refptr<net::IOBuffer> buffer;