Use defer out-params instead of ResourceDispatcherHostImpl::PauseRequest(...true)

content/browser/download/download_request_handle.h

Index: content/browser/download/download_request_handle.h
===================================================================
--- content/browser/download/download_request_handle.h	(revision 136397)
+++ content/browser/download/download_request_handle.h	(working copy)
@@ -9,6 +9,8 @@
 #include <string>
 
 #include "base/compiler_specific.h"
+#include "base/memory/ref_counted.h"
+#include "content/browser/download/download_resource_handler.h"
 #include "content/common/content_export.h"
 
 namespace content {
@@ -45,6 +47,8 @@
 class CONTENT_EXPORT DownloadRequestHandle
     : public DownloadRequestHandleInterface {
  public:
+  virtual ~DownloadRequestHandle();
+
   // Create a null DownloadRequestHandle: getters will return null, and
   // all actions are no-ops.
   // TODO(rdsmith): Ideally, actions would be forbidden rather than
@@ -55,7 +59,8 @@
   DownloadRequestHandle();
 
   // Note that |rdh| is required to be non-null.
-  DownloadRequestHandle(int child_id,
+  DownloadRequestHandle(DownloadResourceHandler* handler,
+                        int child_id,
                         int render_view_id,
                         int request_id);
 
@@ -68,6 +73,8 @@
   virtual std::string DebugString() const OVERRIDE;
 
  private:
+  scoped_refptr<DownloadResourceHandler> handler_;

[Randy Smith (Not in Mondays), 2012/05/17 15:53:48]

Shouldn't this be a weak pointer?  I could easily imagine the handle outliving
the Handler.

[darin (slow to review), 2012/05/17 21:17:57]

It seems OK to extend the lifetime of the Handler.  It is thread-safe ref
counted and it gets destroyed on the IO thread.  A weak pointer would also be OK
since the handler lives as long as the URLRequest, and if the URLRequest is
gone, then there is no point in pausing / resuming / cancelling the URLRequest. 
Hmm... maybe weak is better.

+
   // The ID of the child process that started the download.
   int child_id_;