Use defer out-params instead of ResourceDispatcherHostImpl::PauseRequest(...true)

content/browser/renderer_host/throttling_resource_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/throttling_resource_handler.h"
 
 #include "content/browser/renderer_host/resource_dispatcher_host_impl.h"
 #include "content/public/browser/resource_throttle.h"
 #include "content/public/common/resource_response.h"
 
@@ skipping 56 matching lines @@
     }
   }
 
   index_ = 0;  // Reset for next time.
 
   return next_handler_->OnWillStart(request_id, url, defer);
 }
 
 bool ThrottlingResourceHandler::OnResponseStarted(
     int request_id,
-    content::ResourceResponse* response) {
+    content::ResourceResponse* response,
+    bool* defer) {
   DCHECK_EQ(request_id_, request_id);
 
   while (index_ < throttles_.size()) {
-    bool defer = false;
-    throttles_[index_]->WillProcessResponse(&defer);
+    throttles_[index_]->WillProcessResponse(defer);
     index_++;
-    if (defer) {
-      host_->PauseRequest(child_id_, request_id_, true);
+    if (*defer) {
       deferred_stage_ = DEFERRED_RESPONSE;
       deferred_response_ = response;
       return true;  // Do not cancel.
     }
   }
 
   index_ = 0;  // Reset for next time.

[Randy Smith (Not in Mondays), 2012/05/18 20:17:02]

Not relevant to this CL, just for my curiosity: throttles can't change their
mind after they've said ok?  

[darin (slow to review), 2012/05/18 23:09:05]

In this comment, "next time" refers to the next notification stage.  A throttle
will not see more than one OnResponseStarted event in other words.

 
-  return next_handler_->OnResponseStarted(request_id, response);
+  return next_handler_->OnResponseStarted(request_id, response, defer);
 }
 
 void ThrottlingResourceHandler::OnRequestClosed() {
   throttles_.reset();
   next_handler_->OnRequestClosed();
 }
 
 void ThrottlingResourceHandler::Cancel() {
   host_->CancelRequest(child_id_, request_id_, false);
 }
@@ skipping 42 matching lines @@
     Cancel();
   } else if (!defer) {
     host_->FollowDeferredRedirect(child_id_, request_id_, false, GURL());
   }
 }
 
 void ThrottlingResourceHandler::ResumeResponse() {
   scoped_refptr<ResourceResponse> response;
   deferred_response_.swap(response);
 
-  // OnResponseStarted will pause again if necessary.
-  host_->PauseRequest(child_id_, request_id_, false);
-
-  if (!OnResponseStarted(request_id_, response))
+  bool defer = false;
+  if (!OnResponseStarted(request_id_, response, &defer)) {
     Cancel();
+  } else if (!defer) {
+    host_->ResumeDeferredRequest(child_id_, request_id_);
+  }
 }
 
 }  // namespace content