Issue 10332077: Zoom the web contents 2x such that they are blurry in High DPI

Issue 10332077: Zoom the web contents 2x such that they are blurry in High DPI (Closed)

Created:
8 years, 7 months ago by pkotwicz

Modified:
8 years, 7 months ago

Reviewers:
oshima, piman

CC:
chromium-reviews, yusukes+watch_chromium.org, jonathan.backer, Ian Vollick, grt+watch_chromium.org, amit, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, robertshield, piman+watch_chromium.org, darin-cc_chromium.org, James Su, dhollowa+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Zoom the web contents 2x such that they are blurry in High DPI This patch applies a 2x transform to external textures. This is a quick fix till WebKit takes in DIP. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136220

Patch Set 1 #

Patch Set 2 : Nicer patch #

Total comments: 2

Patch Set 3 : Patch #

Patch Set 4 : Nicer diff #

Total comments: 1

Patch Set 5 : Reviewable patch #

Patch Set 6 : Nicer diff #

Patch Set 7 : Changes as requested #

Patch Set 8 : Change as requested #

Patch Set 9 : Nicer diff #

Patch Set 10 : Change as requested #

Patch Set 11 : Nicer diff #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	ui/compositor/layer.cc	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+11 lines, -4 lines	1 comment	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

oshima

http://codereview.chromium.org/10332077/diff/2001/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (left): http://codereview.chromium.org/10332077/diff/2001/content/browser/renderer_host/render_widget_host_view_aura.cc#oldcode263 content/browser/renderer_host/render_widget_host_view_aura.cc:263: window_->layer()->set_scale_canvas(false); this is necessary http://codereview.chromium.org/10332077/diff/2001/ui/compositor/layer.cc File ui/compositor/layer.cc (right): http://codereview.chromium.org/10332077/diff/2001/ui/compositor/layer.cc#newcode562 ...

8 years, 7 months ago (2012-05-09 19:57:20 UTC) #1

oshima

http://codereview.chromium.org/10332077/diff/8001/ui/compositor/layer.cc File ui/compositor/layer.cc (right): http://codereview.chromium.org/10332077/diff/8001/ui/compositor/layer.cc#newcode312 ui/compositor/layer.cc:312: if (web_layer_is_accelerated_) { DCHECK(texture_); Please add comment + TODO

8 years, 7 months ago (2012-05-09 21:11:58 UTC) #3

piman

lgtm http://codereview.chromium.org/10332077/diff/11003/ui/compositor/layer.cc File ui/compositor/layer.cc (right): http://codereview.chromium.org/10332077/diff/11003/ui/compositor/layer.cc#newcode587 ui/compositor/layer.cc:587: // sizes once WebKit understands DIP. http://crbug.com/127455 Note: ...

8 years, 7 months ago (2012-05-09 23:31:03 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10332077/11003

8 years, 7 months ago (2012-05-09 23:53:09 UTC) #8

Change committed as 136220

Expand Messages | Collapse Messages