Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7264)

Unified Diff: chrome/browser/ui/browser.h

Issue 10332071: Pass command line arguments onto platform apps which provide the right intent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix bad merge Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index 1f9b16e68cfddc5ef14124bcb6a97be93595145b..5fdebabe28a6306d34f6ea31538ba6987ec462f9 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -56,6 +56,7 @@ class BrowserSyncedWindowDelegate;
class BrowserToolbarModelDelegate;
class BrowserTabRestoreServiceDelegate;
class BrowserWindow;
+class CommandLine;
class Extension;
class ExtensionWindowController;
class FindBarController;
@@ -287,13 +288,16 @@ class Browser : public TabStripModelDelegate,
// Open |extension| in |container|, using |disposition| if container type is
// TAB. Returns the WebContents* that was created or NULL. If non-empty,
- // |override_url| is used in place of the app launch url.
+ // |override_url| is used in place of the app launch url. Pass relevant
+ // information in |command_line| onto platform app as launch data.
+ // |command_line| can be NULL, indicating there is no launch data to pass on.
static content::WebContents* OpenApplication(
Mihai Parparita -not on Chrome 2012/05/15 00:39:28 This can be in a follow-up cleanup CL, but OpenApp
benwells 2012/05/18 03:36:02 Agreed. Have added TODO.
Profile* profile,
const Extension* extension,
extension_misc::LaunchContainer container,
const GURL& override_url,
- WindowOpenDisposition disposition);
+ WindowOpenDisposition disposition,
+ const CommandLine* command_line);
#if defined(USE_ASH)
// Opens |url| in a new application panel window for the specified url.

Powered by Google App Engine
This is Rietveld 408576698