Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2289)

Unified Diff: chrome/browser/extensions/api/app/app_api.h

Issue 10332071: Pass command line arguments onto platform apps which provide the right intent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix bad merge Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/app/app_api.h
diff --git a/chrome/browser/extensions/api/app/app_api.h b/chrome/browser/extensions/api/app/app_api.h
index 864deceee2211f4970ea779b98f5844821cb1424..6aa402f20b5c8747a50671061e2b3dc23777a45e 100644
--- a/chrome/browser/extensions/api/app/app_api.h
+++ b/chrome/browser/extensions/api/app/app_api.h
@@ -10,6 +10,7 @@
class Extension;
class Profile;
+class GURL;
namespace extensions {
@@ -33,9 +34,27 @@ class AppClearAllNotificationsFunction : public SyncExtensionFunction {
class AppEventRouter {
public:
- // Dispatches the onLaunched event to the given app.
+ // Dispatches the onLaunched event to the given app, providing no launch
+ // data.
static void DispatchOnLaunchedEvent(Profile* profile,
const Extension* extension);
+
+ // Dispatches the onLaunched event to the given app, providing launch data of
+ // the form:
+ // {
+ // "intent" : {
+ // "action" : |action|,
+ // "type" : |mime_type|,
Greg Billock 2012/05/14 16:16:27 Should also have a "data" field.
benwells 2012/05/14 23:44:32 When sending onLaunched there is no data field. At
Greg Billock 2012/05/14 23:55:38 It's a valid intent, but I was thinking the API wo
benwells 2012/05/15 00:11:46 OK ... this could be added in future but for now I
Mihai Parparita -not on Chrome 2012/05/15 00:39:28 In that case, can "url" be named more specifically
benwells 2012/05/18 03:36:02 url is now gone, with a FileEntry instead in data.
+ // "extra_data" : {
+ // "url" : |url|
+ // }
+ // }
+ // }
+ static void DispatchOnLaunchedEventWithUrl(Profile* profile,
Greg Billock 2012/05/14 16:16:27 How about "DispatchOnLaunchedEventWithIntent" and
benwells 2012/05/15 00:11:46 Yeah that would be nice. I started going down that
Greg Billock 2012/05/15 00:54:59 Couldn't it just be left blank if there's no "data
+ const Extension* extension,
+ const string16& action,
+ const std::string& mime_type,
+ const GURL& url);
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698