Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_ui.cc

Issue 10332049: remove ntp app install hint (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync it Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp/new_tab_ui.h ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/new_tab_ui.cc
diff --git a/chrome/browser/ui/webui/ntp/new_tab_ui.cc b/chrome/browser/ui/webui/ntp/new_tab_ui.cc
index daf0f062dced962cd65c856751d00de649a5a76b..2ad684e7e3400b354d7ffaf62c7edd9122127a7e 100644
--- a/chrome/browser/ui/webui/ntp/new_tab_ui.cc
+++ b/chrome/browser/ui/webui/ntp/new_tab_ui.cc
@@ -14,7 +14,6 @@
#include "base/i18n/rtl.h"
#include "base/lazy_instance.h"
#include "base/memory/singleton.h"
-#include "base/metrics/field_trial.h"
#include "base/metrics/histogram.h"
#include "base/string_number_conversions.h"
#include "base/threading/thread.h"
@@ -79,20 +78,8 @@ const char kLTRHtmlTextDirection[] = "ltr";
static base::LazyInstance<std::set<const WebUIController*> > g_live_new_tabs;
-// Group IDs for the web store link field trial.
-int g_footer_group = 0;
-int g_hint_group = 0;
-
-bool WebStoreLinkExperimentGroupIs(int group) {
- return base::FieldTrialList::TrialExists(kWebStoreLinkExperiment) &&
- base::FieldTrialList::FindValue(kWebStoreLinkExperiment) == group;
-}
-
} // namespace
-// The Web Store footer experiment FieldTrial name.
-const char kWebStoreLinkExperiment[] = "WebStoreLinkExperiment";
-
///////////////////////////////////////////////////////////////////////////////
// NewTabUI
@@ -286,35 +273,6 @@ void NewTabUI::RegisterUserPrefs(PrefService* prefs) {
}
// static
-void NewTabUI::SetupFieldTrials() {
- scoped_refptr<base::FieldTrial> trial(
- base::FieldTrialList::FactoryGetFieldTrial(
- kWebStoreLinkExperiment, 1, "Disabled", 2025, 6, 1, NULL));
-
- // Try to give the user a consistent experience, if possible.
- if (base::FieldTrialList::IsOneTimeRandomizationEnabled())
- trial->UseOneTimeRandomization();
-
- // 33.3% in each group.
- g_footer_group = trial->AppendGroup("FooterLink", 1);
- g_hint_group = trial->AppendGroup("PlusIcon", 0);
-}
-
-// static
-bool NewTabUI::ShouldShowWebStoreFooterLink() {
- const CommandLine* cli = CommandLine::ForCurrentProcess();
- return cli->HasSwitch(switches::kEnableWebStoreLink) ||
- WebStoreLinkExperimentGroupIs(g_footer_group);
-}
-
-// static
-bool NewTabUI::ShouldShowAppInstallHint() {
- const CommandLine* cli = CommandLine::ForCurrentProcess();
- return cli->HasSwitch(switches::kNtpAppInstallHint) ||
- WebStoreLinkExperimentGroupIs(g_hint_group);
-}
-
-// static
bool NewTabUI::ShouldShowApps() {
#if defined(USE_ASH) || defined(OS_ANDROID)
// Ash shows apps in app list thus should not show apps page in NTP4.
« no previous file with comments | « chrome/browser/ui/webui/ntp/new_tab_ui.h ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698