remove ntp app install hint

chrome/browser/resources/ntp4/apps_page.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('ntp', function() {
   'use strict';
 
   var APP_LAUNCH = {
     // The histogram buckets (keep in sync with extension_constants.h).
     NTP_APPS_MAXIMIZED: 0,
     NTP_APPS_COLLAPSED: 1,
     NTP_APPS_MENU: 2,
     NTP_MOST_VISITED: 3,
     NTP_RECENTLY_CLOSED: 4,
     NTP_APP_RE_ENABLE: 16,
     NTP_WEBSTORE_FOOTER: 18,
     NTP_WEBSTORE_PLUS_ICON: 19,
   };
 
   // Histogram buckets for UMA tracking of where a DnD drop came from.
   var DRAG_SOURCE = {
     SAME_APPS_PANE: 0,
     OTHER_APPS_PANE: 1,
     MOST_VISITED_PANE: 2,
     BOOKMARKS_PANE: 3,
     OUTSIDE_NTP: 4
   };
   var DRAG_SOURCE_LIMIT = DRAG_SOURCE.OUTSIDE_NTP + 1;
 
-  /** @const */ var appInstallHintTileLimit = 10;
-
   /**
    * App context menu. The class is designed to be used as a singleton with
    * the app that is currently showing a context menu stored in this.app_.
    * @constructor
    */
   function AppContextMenu() {
     this.__proto__ = AppContextMenu.prototype;
     this.initialize();
   }
   cr.addSingletonGetter(AppContextMenu);
@@ skipping 599 matching lines @@
 
     return el;
   }
 
   AppsPage.prototype = {
     __proto__: TilePage.prototype,
 
     initialize: function() {
       this.classList.add('apps-page');
 
-      if (loadTimeData.getBoolean('appInstallHintEnabled')) {
-        this.appInstallHint_ = $('app-install-hint-template').cloneNode(true);
-        this.appInstallHint_.addEventListener('click', function(e) {
-          chrome.send('recordAppLaunchByURL',
-              [encodeURIComponent(this.href),
-               APP_LAUNCH.NTP_WEBSTORE_PLUS_ICON]);
-        });
-        this.content_.appendChild(this.appInstallHint_);
-      }
-
       this.addEventListener('cardselected', this.onCardSelected_);
       // Add event listeners for two events, so we can temporarily suppress
       // the app notification bubbles when the app card slides in and out of
       // view.
       this.addEventListener('carddeselected', this.onCardDeselected_);
       this.addEventListener('cardSlider:card_change_ended',
                             this.onCardChangeEnded_);
 
       this.addEventListener('tilePage:tile_added', this.onTileAdded_);
 
       this.content_.addEventListener('scroll', this.onScroll_.bind(this));
     },
 
     /**
      * Creates an app DOM element and places it at the last position on the
      * page.
      * @param {Object} appData The data object that describes the app.
      * @param {boolean=} animate If true, the app tile plays an animation.
      */
     appendApp: function(appData, animate) {
       if (animate) {
         // Select the page and scroll all the way down so the animation is
         // visible.
         ntp.getCardSlider().selectCardByValue(this);
         this.content_.scrollTop = this.content_.scrollHeight;
       }
 
       this.appendTile(new App(appData), animate);
-      this.hintStateMayHaveChanged_();
     },
 
     /**
      * Similar to appendApp, but it respects the app_launch_ordinal field of
      * |appData|.
      * @param {Object} appData The data that describes the app.
      */
     insertApp: function(appData) {
       var index = 0;
       for (var i = 0; i < this.tileElements_.length; i++) {
         if (appData.app_launch_ordinal <
             this.tileElements_[i].firstChild.appData.app_launch_ordinal) {
           index = i;
           break;
         }
       }
 
       this.addTileAt(new App(appData), index, false);
-      this.hintStateMayHaveChanged_();
     },
 
     /**
      * Handler for 'cardselected' event, fired when |this| is selected. The
      * first time this is called, we load all the app icons.
      * @private
      */
     onCardSelected_: function(e) {
       var apps = this.querySelectorAll('.app.icon-loading');
       for (var i = 0; i < apps.length; i++) {
@@ skipping 177 matching lines @@
     },
 
     /** @inheritDoc */
     setDropEffect: function(dataTransfer) {
       var tile = ntp.getCurrentlyDraggingTile();
       if (tile && tile.querySelector('.app'))
         ntp.setCurrentDropEffect(dataTransfer, 'move');
       else
         ntp.setCurrentDropEffect(dataTransfer, 'copy');
     },
-
-    /**
-     * Called when we may need to change app install hint visibility.
-     * @private
-     */
-    hintStateMayHaveChanged_: function() {
-      if (this.updateHintState_())
-        this.repositionTiles_();
-      else
-        this.repositionHint_();
-    },
-
-    /**
-     * Updates whether the app install hint is visible. Returns true if we need
-     * to reposition other tiles (because webstore app changed visibility).
-     * @private
-     */
-    updateHintState_: function() {
-      if (!this.appInstallHint_)
-        return;
-
-      var appsPages = document.querySelectorAll('.apps-page');
-      var numTiles = this.tileElements_.length;
-      var showHint =
-          numTiles < appInstallHintTileLimit && appsPages.length == 1;
-      this.appInstallHint_.hidden = !showHint;
-
-      var webstoreApp = this.querySelector('.webstore');
-      if (!webstoreApp)
-        return false;
-
-      var webstoreTile = findAncestorByClass(webstoreApp, 'tile');
-      if (showHint) {
-        if (!webstoreTile.classList.contains('real'))
-          return false;
-
-        webstoreTile.classList.remove('real');
-        return true;
-      }
-
-      if (webstoreTile.classList.contains('real'))
-        return false;
-
-      webstoreTile.classList.add('real');
-      return true;
-    },
-
-    /**
-     * Repositions the app tile hint (to be called when tiles move).
-     * @private
-     */
-    repositionHint_: function() {
-      if (!this.appInstallHint_ || this.appInstallHint_.hidden)
-        return;
-
-      var index = this.tileElements_.length;
-      var layout = this.layoutValues_;
-      var col = index % layout.numRowTiles;
-      var row = Math.floor(index / layout.numRowTiles);
-      var realX = this.tileGrid_.offsetLeft +
-          col * layout.colWidth + layout.leftMargin;
-
-      var realY =
-          this.topMarginPx_ + row * layout.rowHeight + this.contentPadding;
-
-      this.appInstallHint_.style.left = realX + 'px';
-      this.appInstallHint_.style.right = realX + 'px';
-      this.appInstallHint_.style.top = realY + 'px';
-      this.appInstallHint_.style.width = layout.tileWidth + 'px';
-      this.appInstallHint_.style.height = layout.tileWidth + 'px';
-    },
-
-    /** @inheritDoc */
-    repositionTiles_: function(ignoreNode) {
-      TilePage.prototype.repositionTiles_.call(this, ignoreNode);
-      this.repositionHint_();
-    },
   };
 
   AppsPage.setPromo = function(data) {
     var store = document.querySelector('.webstore');
     if (store)
       store.setAppsPromoData(data);
   };
 
   /**
    * Launches the specified app using the APP_LAUNCH_NTP_APP_RE_ENABLE
@@ skipping 11 matching lines @@
       app.setupNotification_(notification);
   }
 
   return {
     APP_LAUNCH: APP_LAUNCH,
     appNotificationChanged: appNotificationChanged,
     AppsPage: AppsPage,
     launchAppAfterEnable: launchAppAfterEnable,
   };
 });