remove ntp app install hint

remove ntp app install hint

BUG=126148
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136216

[Dan Beam, 2012-05-08 18:24:19]

lgtm w/nits

http://codereview.chromium.org/10332049/diff/1/chrome/browser/resources/ntp4/...
File chrome/browser/resources/ntp4/new_tab.css (right):

http://codereview.chromium.org/10332049/diff/1/chrome/browser/resources/ntp4/...
chrome/browser/resources/ntp4/new_tab.css:375: #chrome-web-store-href {
why does this end with -href again?

http://codereview.chromium.org/10332049/diff/1/chrome/browser/resources/ntp4/...
chrome/browser/resources/ntp4/new_tab.css:381: display: inline-block;
I still think we should investigate more compact ways of showing this, or hide
when the screen size is small. For example:

  #chrome-web-store-href {
    display: none;
  }

  @media screen and (min-width: 1025px) {
    #chrome-web-store-href {
      display: inline-block;
    }
  }

[Evan Stade, 2012-05-08 19:01:33]

http://codereview.chromium.org/10332049/diff/1/chrome/browser/resources/ntp4/...
File chrome/browser/resources/ntp4/new_tab.css (right):

http://codereview.chromium.org/10332049/diff/1/chrome/browser/resources/ntp4/...
chrome/browser/resources/ntp4/new_tab.css:375: #chrome-web-store-href {
On 2012/05/08 18:24:19, Dan Beam wrote:
> why does this end with -href again?

because it's a hypertext reference?

yea, should be link I guess.

http://codereview.chromium.org/10332049/diff/1/chrome/browser/resources/ntp4/...
chrome/browser/resources/ntp4/new_tab.css:381: display: inline-block;
On 2012/05/08 18:24:19, Dan Beam wrote:
> I still think we should investigate more compact ways of showing this, or hide
> when the screen size is small. For example:
> 
>   #chrome-web-store-href {
>     display: none;
>   }
> 
>   @media screen and (min-width: 1025px) {
>     #chrome-web-store-href {
>       display: inline-block;
>     }
>   }

I personally think that's a good idea (for some value of min-width) but the
first step is to get alcor or whoever to approve that. While we're at it, we
could hide the logo as well as that's taking up as much or more space, and is
more useless.

[commit-bot: I haz the power, 2012-05-08 19:01:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/10332049/7001

[Dan Beam, 2012-05-08 19:08:56]

On 2012/05/08 19:01:33, Evan Stade wrote:
>
http://codereview.chromium.org/10332049/diff/1/chrome/browser/resources/ntp4/...
> File chrome/browser/resources/ntp4/new_tab.css (right):
> 
>
http://codereview.chromium.org/10332049/diff/1/chrome/browser/resources/ntp4/...
> chrome/browser/resources/ntp4/new_tab.css:375: #chrome-web-store-href {
> On 2012/05/08 18:24:19, Dan Beam wrote:
> > why does this end with -href again?
> 
> because it's a hypertext reference?
> 
> yea, should be link I guess.

agreed

>
http://codereview.chromium.org/10332049/diff/1/chrome/browser/resources/ntp4/...
> chrome/browser/resources/ntp4/new_tab.css:381: display: inline-block;
> On 2012/05/08 18:24:19, Dan Beam wrote:
> > I still think we should investigate more compact ways of showing this, or
hide
> > when the screen size is small. For example:
> > 
> >   #chrome-web-store-href {
> >     display: none;
> >   }
> > 
> >   @media screen and (min-width: 1025px) {
> >     #chrome-web-store-href {
> >       display: inline-block;
> >     }
> >   }
> 
> I personally think that's a good idea (for some value of min-width) but the
> first step is to get alcor or whoever to approve that. While we're at it, we
> could hide the logo as well as that's taking up as much or more space, and is
> more useless.

fo sho

[commit-bot: I haz the power, 2012-05-08 19:23:10]

Try job failure for 10332049-7001 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-05-08 23:20:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/10332049/7001

[commit-bot: I haz the power, 2012-05-08 23:52:06]

Try job failure for 10332049-7001 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-05-09 23:44:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/10332049/11004

[commit-bot: I haz the power, 2012-05-10 01:36:43]

Change committed as 136216