Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10332002: win: Fix a few minor issues found by clang. (Closed)

Created:
8 years, 7 months ago by Nico
Modified:
8 years, 7 months ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

win: Fix a few minor issues found by clang. No intended functionality change. BUG=82385 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134988

Patch Set 1 #

Total comments: 3

Patch Set 2 : rsleevi #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -19 lines) Patch
M chrome/browser/chrome_browser_main_win.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/rsa_private_key_win.cc View 1 2 chunks +4 lines, -10 lines 0 comments Download
M sandbox/src/Wow64.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/src/sandbox_nt_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/src/target_process.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/src/target_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/platform_font_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/monitor_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
https://chromiumcodereview.appspot.com/10332002/diff/1/ui/gfx/platform_font_win.cc File ui/gfx/platform_font_win.cc (right): https://chromiumcodereview.appspot.com/10332002/diff/1/ui/gfx/platform_font_win.cc#newcode225 ui/gfx/platform_font_win.cc:225: base::win::ScopedSelectObject scoped_font(screen_dc, font); This one might actually fix a ...
8 years, 7 months ago (2012-05-02 17:34:35 UTC) #1
Ryan Sleevi
https://chromiumcodereview.appspot.com/10332002/diff/1/crypto/rsa_private_key_win.cc File crypto/rsa_private_key_win.cc (right): https://chromiumcodereview.appspot.com/10332002/diff/1/crypto/rsa_private_key_win.cc#newcode20 crypto/rsa_private_key_win.cc:20: return NULL; \ Given there is only one instance ...
8 years, 7 months ago (2012-05-02 18:11:30 UTC) #2
Nico
https://chromiumcodereview.appspot.com/10332002/diff/1/crypto/rsa_private_key_win.cc File crypto/rsa_private_key_win.cc (right): https://chromiumcodereview.appspot.com/10332002/diff/1/crypto/rsa_private_key_win.cc#newcode20 crypto/rsa_private_key_win.cc:20: return NULL; \ On 2012/05/02 18:11:30, Ryan Sleevi wrote: ...
8 years, 7 months ago (2012-05-02 18:14:19 UTC) #3
Nico
s/sky/ben/, sky seems afk
8 years, 7 months ago (2012-05-02 18:17:55 UTC) #4
Ryan Sleevi
lgtm
8 years, 7 months ago (2012-05-02 18:18:29 UTC) #5
Ben Goodger (Google)
LGTM
8 years, 7 months ago (2012-05-02 19:00:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10332002/7002
8 years, 7 months ago (2012-05-02 19:02:54 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-02 20:48:07 UTC) #8 
Change committed as 134988

Powered by Google App Engine
This is Rietveld 408576698