Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 10323002: Move message handlers that don't belong in RenderProcessHostImpl to their own files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: threaded Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 5d54b170076ee49c23299c4d37fd9ee7e5e4235c..2f9d3e96d71550b52c50c08256b9ae3bc5fb6a93 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -902,8 +902,10 @@ bool RenderProcessHostImpl::OnMessageReceived(const IPC::Message& msg) {
SuddenTerminationChanged)
IPC_MESSAGE_HANDLER(ViewHostMsg_UserMetricsRecordAction,
OnUserMetricsRecordAction)
- IPC_MESSAGE_HANDLER(ViewHostMsg_RevealFolderInOS, OnRevealFolderInOS)
IPC_MESSAGE_HANDLER(ViewHostMsg_SavedPageAsMHTML, OnSavedPageAsMHTML)
+ // Adding single handlers for your service here is fine, but once your
+ // service needs more than one handler, please extract them into a new
+ // message filter and add that filter to CreateMessageFilters().
IPC_MESSAGE_UNHANDLED_ERROR()
IPC_END_MESSAGE_MAP_EX()
@@ -1364,12 +1366,6 @@ void RenderProcessHostImpl::OnUserMetricsRecordAction(
content::RecordComputedAction(action);
}
-void RenderProcessHostImpl::OnRevealFolderInOS(const FilePath& path) {
- // Only honor the request if appropriate persmissions are granted.
- if (ChildProcessSecurityPolicyImpl::GetInstance()->CanReadFile(GetID(),
- path))
- content::GetContentClient()->browser()->OpenItem(path);
-}
void RenderProcessHostImpl::OnSavedPageAsMHTML(int job_id, int64 data_size) {
MHTMLGenerationManager::GetInstance()->MHTMLGenerated(job_id, data_size);

Powered by Google App Engine
This is Rietveld 408576698