Wire up the policy for controlling pinned apps in the ash launcher.

Wire up the policy for controlling pinned apps in the ash launcher.

This declares the policy so the policy subsystem can enforce it and
shows it in about:policy.

BUG=chromium-os:29917
TEST=Configure pinned apps, log in as a managed user, observe that the launcher shows the pinned apps as configured.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135677

[Mattias Nissler (ping if slow), 2012-05-03 18:13:09]

Monsieur, here is something for your reviewing pleasure! :)

[Joao da Silva, 2012-05-03 18:41:21]

http://codereview.chromium.org/10316022/diff/1/chrome/app/policy/policy_templ...
File chrome/app/policy/policy_templates.json (right):

http://codereview.chromium.org/10316022/diff/1/chrome/app/policy/policy_templ...
chrome/app/policy/policy_templates.json:2655: If this policy is left unset, the
user may change the list of pinned apps in the launcher..''',
nit: one .

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/configur...
File chrome/browser/policy/configuration_policy_handler.cc (right):

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/configur...
chrome/browser/policy/configuration_policy_handler.cc:208: //
ExtensionListPolicyHandler implementation -----------------------------------
nit: newline

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/configur...
File chrome/browser/policy/configuration_policy_handler_chromeos.cc (right):

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/configur...
chrome/browser/policy/configuration_policy_handler_chromeos.cc:151:
base::DictionaryValue* app_dict = new DictionaryValue();
nit: base::Dictionary

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/configur...
File chrome/browser/policy/configuration_policy_handler_list.cc (left):

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/configur...
chrome/browser/policy/configuration_policy_handler_list.cc:87: {
key::kExtensionInstallForcelist,
Why not this one too?

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/policy_e...
File chrome/browser/policy/policy_error_map.cc (right):

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/policy_e...
chrome/browser/policy/policy_error_map.cc:26: message_id(message_id),
Don't you want to store the |index| here?

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/policy_e...
chrome/browser/policy/policy_error_map.cc:36: message_id(message_id),
Same

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/policy_e...
File chrome/browser/policy/policy_error_map.h (right):

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/policy_e...
chrome/browser/policy/policy_error_map.h:71: 
nit: one newline

[Mattias Nissler (ping if slow), 2012-05-03 20:13:04]

http://codereview.chromium.org/10316022/diff/1/chrome/app/policy/policy_templ...
File chrome/app/policy/policy_templates.json (right):

http://codereview.chromium.org/10316022/diff/1/chrome/app/policy/policy_templ...
chrome/app/policy/policy_templates.json:2655: If this policy is left unset, the
user may change the list of pinned apps in the launcher..''',
On 2012/05/03 18:41:22, Joao da Silva wrote:
> nit: one .

Done.

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/configur...
File chrome/browser/policy/configuration_policy_handler.cc (right):

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/configur...
chrome/browser/policy/configuration_policy_handler.cc:208: //
ExtensionListPolicyHandler implementation -----------------------------------
On 2012/05/03 18:41:22, Joao da Silva wrote:
> nit: newline

Done.

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/configur...
File chrome/browser/policy/configuration_policy_handler_chromeos.cc (right):

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/configur...
chrome/browser/policy/configuration_policy_handler_chromeos.cc:151:
base::DictionaryValue* app_dict = new DictionaryValue();
On 2012/05/03 18:41:22, Joao da Silva wrote:
> nit: base::Dictionary

Done.

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/configur...
File chrome/browser/policy/configuration_policy_handler_list.cc (left):

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/configur...
chrome/browser/policy/configuration_policy_handler_list.cc:87: {
key::kExtensionInstallForcelist,
On 2012/05/03 18:41:22, Joao da Silva wrote:
> Why not this one too?

Because its format is different: <ID>;<UpdateURL>

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/policy_e...
File chrome/browser/policy/policy_error_map.cc (right):

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/policy_e...
chrome/browser/policy/policy_error_map.cc:26: message_id(message_id),
On 2012/05/03 18:41:22, Joao da Silva wrote:
> Don't you want to store the |index| here?

Yes, definitely. Thanks for catching. Done.

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/policy_e...
chrome/browser/policy/policy_error_map.cc:36: message_id(message_id),
On 2012/05/03 18:41:22, Joao da Silva wrote:
> Same

Done.

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/policy_e...
File chrome/browser/policy/policy_error_map.h (right):

http://codereview.chromium.org/10316022/diff/1/chrome/browser/policy/policy_e...
chrome/browser/policy/policy_error_map.h:71: 
On 2012/05/03 18:41:22, Joao da Silva wrote:
> nit: one newline

Done.

[Joao da Silva, 2012-05-04 08:32:57]

lgtm

Please see the bot failures :-)