Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: chrome/browser/prerender/prerender_tab_helper.h

Issue 10316020: Remove WebContentsImpl::OnDidRedirectProvisionalLoad. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ...and remove from WebContentsObserver. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PRERENDER_PRERENDER_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_PRERENDER_PRERENDER_TAB_HELPER_H_
6 #define CHROME_BROWSER_PRERENDER_PRERENDER_TAB_HELPER_H_ 6 #define CHROME_BROWSER_PRERENDER_PRERENDER_TAB_HELPER_H_
7 7
8 #include "base/time.h" 8 #include "base/time.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "content/public/browser/web_contents_observer.h" 10 #include "content/public/browser/web_contents_observer.h"
11 #include "googleurl/src/gurl.h" 11 #include "googleurl/src/gurl.h"
12 12
13 class TabContentsWrapper; 13 class TabContentsWrapper;
14 14
15 namespace prerender { 15 namespace prerender {
16 16
17 class PrerenderManager; 17 class PrerenderManager;
18 18
19 // PrerenderTabHelper is responsible for recording perceived pageload times 19 // PrerenderTabHelper is responsible for recording perceived pageload times
20 // to compare PLT's with prerendering enabled and disabled. 20 // to compare PLT's with prerendering enabled and disabled.
21 class PrerenderTabHelper : public content::WebContentsObserver { 21 class PrerenderTabHelper : public content::WebContentsObserver {
22 public: 22 public:
23 explicit PrerenderTabHelper(TabContentsWrapper* tab); 23 explicit PrerenderTabHelper(TabContentsWrapper* tab);
24 virtual ~PrerenderTabHelper(); 24 virtual ~PrerenderTabHelper();
25 25
26 // content::WebContentsObserver implementation. 26 // content::WebContentsObserver implementation.
27 virtual void ProvisionalChangeToMainFrameUrl(
28 const GURL& url,
29 const GURL& opener_url) OVERRIDE;
30 virtual void DidStopLoading() OVERRIDE; 27 virtual void DidStopLoading() OVERRIDE;
31 virtual void DidStartProvisionalLoadForFrame( 28 virtual void DidStartProvisionalLoadForFrame(
32 int64 frame_id, 29 int64 frame_id,
33 bool is_main_frame, 30 bool is_main_frame,
34 const GURL& validated_url, 31 const GURL& validated_url,
35 bool is_error_page, 32 bool is_error_page,
36 content::RenderViewHost* render_view_host) OVERRIDE; 33 content::RenderViewHost* render_view_host) OVERRIDE;
37 virtual void DidCommitProvisionalLoadForFrame( 34 virtual void DidCommitProvisionalLoadForFrame(
38 int64 frame_id, 35 int64 frame_id,
39 bool is_main_frame, 36 bool is_main_frame,
(...skipping 25 matching lines...) Expand all
65 62
66 // Current URL being loaded. 63 // Current URL being loaded.
67 GURL url_; 64 GURL url_;
68 65
69 DISALLOW_COPY_AND_ASSIGN(PrerenderTabHelper); 66 DISALLOW_COPY_AND_ASSIGN(PrerenderTabHelper);
70 }; 67 };
71 68
72 } // namespace prerender 69 } // namespace prerender
73 70
74 #endif // CHROME_BROWSER_PRERENDER_PRERENDER_TAB_HELPER_H_ 71 #endif // CHROME_BROWSER_PRERENDER_PRERENDER_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_tab_helper.cc » ('j') | chrome/browser/prerender/prerender_tab_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698