Issue 10315013: ash: Fix a couple issues in ChromeShellDelegate::Search

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10315013: ash: Fix a couple issues in ChromeShellDelegate::Search (Closed)

Created:
8 years, 7 months ago by xiyuan

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Fix a couple issues in ChromeShellDelegate::Search - Fix the crash caused by NULL returned from GetSelectedWebContents which happens for new browser that has no tabs; - Make sure target_browser's window is shown; BUG=126115 TEST=Verify fix for issue 126115. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135259

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/ui/views/ash/chrome_shell_delegate.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10315013/1

8 years, 7 months ago (2012-05-03 22:27:27 UTC) #3

Change committed as 135259

Expand Messages | Collapse Messages