Added base::win::InitializeWindowClass() wrapper to make sure that window classes are properly asso…

ui/base/win/window_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/win/window_impl.h"
 
 #include <list>
 
 #include "base/debug/alias.h"
 #include "base/memory/singleton.h"
@@ skipping 33 matching lines @@
 
 class ClassRegistrar {
  public:
   static ClassRegistrar* GetInstance() {
     return Singleton<ClassRegistrar>::get();
   }
 
   ~ClassRegistrar() {
     for (RegisteredClasses::iterator i = registered_classes_.begin();
          i != registered_classes_.end(); ++i) {
-      if (!UnregisterClass(i->name.c_str(), NULL)) {
+      if (!UnregisterClass(MAKEINTATOM(i->atom), i->instance)) {
         LOG(ERROR) << "Failed to unregister class " << i->name.c_str()
                    << ". Error = " << GetLastError();
       }
     }
   }
 
   // Puts the name for the class matching |class_info| in |class_name|, creating
   // a new name if the class is not yet known.
   // Returns true if this class was already known, false otherwise.
   bool RetrieveClassName(const ClassInfo& class_info, std::wstring* name) {
     for (RegisteredClasses::const_iterator i = registered_classes_.begin();
          i != registered_classes_.end(); ++i) {
       if (class_info.Equals(i->info)) {
         name->assign(i->name);
         return true;
       }
     }
 
     name->assign(string16(WindowImpl::kBaseClassName) +
         base::IntToString16(registered_count_++));
     return false;
   }
 
   void RegisterClass(const ClassInfo& class_info,
                      const std::wstring& name,
-                     ATOM atom) {
-    registered_classes_.push_back(RegisteredClass(class_info, name, atom));
+                     ATOM atom,
+                     HMODULE instance) {
+    registered_classes_.push_back(
+        RegisteredClass(class_info, name, atom, instance));
   }
 
  private:
   // Represents a registered window class.
   struct RegisteredClass {
     RegisteredClass(const ClassInfo& info,
                     const std::wstring& name,
-                    ATOM atom)
+                    ATOM atom,
+                    HMODULE instance)
         : info(info),
           name(name),
-          atom(atom) {
+          atom(atom),
+          instance(instance) {
     }
 
     // Info used to create the class.
     ClassInfo info;
 
-    // The name given to the window.
+    // The name given to the window class.
     std::wstring name;
 
-    // The ATOM returned from creating the window.
+    // The ATOM returned from registering the window class.
     ATOM atom;
+
+    // The handle of the module containing the window procedure.
+    HMODULE instance;
   };
 
   ClassRegistrar() : registered_count_(0) { }
   friend struct DefaultSingletonTraits<ClassRegistrar>;
 
   typedef std::list<RegisteredClass> RegisteredClasses;
   RegisteredClasses registered_classes_;
 
   // Counter of how many classes have been registered so far.
   int registered_count_;
@@ skipping 121 matching lines @@
 
 std::wstring WindowImpl::GetWindowClassName() {
   HICON icon = GetDefaultWindowIcon();
   ClassInfo class_info(initial_class_style(), icon);
   std::wstring name;
   if (ClassRegistrar::GetInstance()->RetrieveClassName(class_info, &name))
     return name;
 
   // No class found, need to register one.
   HBRUSH background = NULL;
-  WNDCLASSEX class_ex = {
-    sizeof(WNDCLASSEX),
-    class_info.style,
-    base::win::WrappedWindowProc<&WindowImpl::WndProc>,
-    0,
-    0,
-    GetModuleHandle(NULL),
-    icon,
-    NULL,
-    reinterpret_cast<HBRUSH>(background + 1),
-    NULL,
-    name.c_str(),
-    icon
-  };
-  ATOM atom = RegisterClassEx(&class_ex);
+  WNDCLASSEX window_class;
+  base::win::InitializeWindowClass(
+      name.c_str(),
+      &base::win::WrappedWindowProc<WindowImpl::WndProc>,
+      class_info.style,
+      0,
+      0,
+      NULL,
+      reinterpret_cast<HBRUSH>(background + 1),
+      NULL,
+      icon,
+      icon,
+      &window_class);
+  HMODULE instance = window_class.hInstance;
+  ATOM atom = RegisterClassEx(&window_class);
   CHECK(atom) << GetLastError();
 
-  ClassRegistrar::GetInstance()->RegisterClass(class_info, name, atom);
+  ClassRegistrar::GetInstance()->RegisterClass(
+      class_info, name, atom, instance);
 
   return name;
 }
 
 }  // namespace ui