Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: net/proxy/proxy_config_service_linux.cc

Issue 10310179: Track sources of proxy settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_config_service_linux.cc
diff --git a/net/proxy/proxy_config_service_linux.cc b/net/proxy/proxy_config_service_linux.cc
index c05e84fa2aedb116f3a332d354a2eed0cd5364d3..243d2c741a71b804b26995defe35eb7d5420da79 100644
--- a/net/proxy/proxy_config_service_linux.cc
+++ b/net/proxy/proxy_config_service_linux.cc
@@ -320,8 +320,8 @@ class SettingGetterImplGConf : public ProxyConfigServiceLinux::SettingGetter {
return loop_;
}
- virtual const char* GetDataSource() OVERRIDE {
- return "gconf";
+ virtual ProxyConfigSource GetConfigSource() OVERRIDE {
+ return PROXY_CONFIG_SOURCE_GCONF;
}
virtual bool GetString(StringSetting key, std::string* result) OVERRIDE {
@@ -638,8 +638,8 @@ class SettingGetterImplGSettings
return loop_;
}
- virtual const char* GetDataSource() OVERRIDE {
- return "gsettings";
+ virtual ProxyConfigSource GetConfigSource() OVERRIDE {
+ return PROXY_CONFIG_SOURCE_GSETTINGS;
}
virtual bool GetString(StringSetting key, std::string* result) OVERRIDE {
@@ -1046,8 +1046,8 @@ class SettingGetterImplKDE : public ProxyConfigServiceLinux::SettingGetter,
NOTREACHED();
}
- virtual const char* GetDataSource() OVERRIDE {
- return "KDE";
+ virtual ProxyConfigSource GetConfigSource() OVERRIDE {
+ return PROXY_CONFIG_SOURCE_KDE;
}
virtual bool GetString(StringSetting key, std::string* result) OVERRIDE {
@@ -1637,8 +1637,9 @@ void ProxyConfigServiceLinux::Delegate::SetUpAndFetchInitialConfig(
setting_getter_->Init(glib_default_loop, file_loop) &&
GetConfigFromSettings(&cached_config_)) {
cached_config_.set_id(1); // Mark it as valid.
+ cached_config_.set_source(setting_getter_->GetConfigSource());
VLOG(1) << "Obtained proxy settings from "
- << setting_getter_->GetDataSource();
+ << ProxyConfigSourceToString(cached_config_.source());
// If gconf proxy mode is "none", meaning direct, then we take
// that to be a valid config and will not check environment
@@ -1678,6 +1679,7 @@ void ProxyConfigServiceLinux::Delegate::SetUpAndFetchInitialConfig(
// Consulting environment variables doesn't need to be done from the
// default glib main loop, but it's a tiny enough amount of work.
if (GetConfigFromEnv(&cached_config_)) {
+ cached_config_.set_source(PROXY_CONFIG_SOURCE_ENV);
cached_config_.set_id(1); // Mark it as valid.
VLOG(1) << "Obtained proxy settings from environment variables";
}

Powered by Google App Engine
This is Rietveld 408576698