Track sources of proxy settings.

net/proxy/proxy_config_source.h

Index: net/proxy/proxy_config_source.h
diff --git a/net/proxy/proxy_config_source.h b/net/proxy/proxy_config_source.h
new file mode 100644
index 0000000000000000000000000000000000000000..a1b0cce12b5247fe42c41ce8cd4fa22078d97b44
--- /dev/null
+++ b/net/proxy/proxy_config_source.h
@@ -0,0 +1,39 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_PROXY_PROXY_CONFIG_SOURCE_H_
+#define NET_PROXY_PROXY_CONFIG_SOURCE_H_
+#pragma once
+
+namespace net {
+
+// Source of the configuration settings encapsulated in a ProxyConfig object.
+
+// The source information is used for credentials use policy determination and

[eroman, 2012/06/11 23:18:34]

"for credentials use policy determination" doesn't sound right, is there a word
missing or too many?

[asanka, 2012/06/12 19:37:18]

Reworded.

+// logging.  When adding new values, remember to add a string to kSourceNames[]
+// in proxy_config_source.cc.
+enum ProxyConfigSource {
+  PROXY_CONFIG_SOURCE_UNKNOWN,       // The source hasn't been set.
+  PROXY_CONFIG_SOURCE_NONE,          // No explicit proxy settings.

[eroman, 2012/06/11 23:18:34]

I don't think we should have this, can it be deleted?

I think the existing user of SOURCE_NONE can either be set to SOURCE_UNKNOWN or
SOURCE_CUSTOM.

[asanka, 2012/06/12 19:37:18]

Done. Went with SOURCE_UNKNOWN.

+  PROXY_CONFIG_SOURCE_SYSTEM,        // System settings (Win/Mac).
+  PROXY_CONFIG_SOURCE_SYSTEM_FAILED, // Default settings after failure to
+                                     // determine system settings.
+  PROXY_CONFIG_SOURCE_GCONF,         // GConf (Linux)
+  PROXY_CONFIG_SOURCE_GSETTINGS,     // GSettings (Linux).
+  PROXY_CONFIG_SOURCE_KDE,           // KDE (Linux).
+  PROXY_CONFIG_SOURCE_ENV,           // Environment variables.
+  PROXY_CONFIG_SOURCE_CUSTOM,        // Custom settings local to the
+                                     // application (command line,
+                                     // extensions, application
+                                     // specific preferences, etc.)
+  PROXY_CONFIG_SOURCE_TEST,          // Test settings.
+  NUM_PROXY_CONFIG_SOURCES
+};
+
+// Returns a textual representation of the source.
+const char* ProxyConfigSourceToString(ProxyConfigSource source);
+
+}  // namespace

[eroman, 2012/06/11 23:18:34]

namespace net

[asanka, 2012/06/12 19:37:18]

Done.

+
+#endif  // NET_PROXY_PROXY_CONFIG_SOURCE_H_