Simplify v8.gyp.

Simplify v8.gyp.

This matches how BUILDING_V8_SHARED is set in other places
in this file. No intended functionality change.


r11586

[Nico, 2012-05-14 23:48:16]

This is necessary for a future change I'd like to make (basically,
http://codereview.chromium.org/10386108/ for v8).

https://chromiumcodereview.appspot.com/10310156/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://chromiumcodereview.appspot.com/10310156/diff/1/tools/gyp/v8.gyp#newco...
tools/gyp/v8.gyp:729: 'V8_SHARED',
See here.

[Yang, 2012-05-15 09:24:42]

On 2012/05/14 23:48:16, Nico wrote:
> This is necessary for a future change I'd like to make (basically,
> http://codereview.chromium.org/10386108/ for v8).
> 
> https://chromiumcodereview.appspot.com/10310156/diff/1/tools/gyp/v8.gyp
> File tools/gyp/v8.gyp (right):
> 
>
https://chromiumcodereview.appspot.com/10310156/diff/1/tools/gyp/v8.gyp#newco...
> tools/gyp/v8.gyp:729: 'V8_SHARED',
> See here.

Please base the patch on svn/bleeding_edge instead of svn/trunk.

[fschneider, 2012-05-15 12:58:11]

Redirecting to jkummerow@, as he is the V8 gyp guy.

[Nico, 2012-05-15 13:45:21]

On 2012/05/15 09:24:42, Yang wrote:
> On 2012/05/14 23:48:16, Nico wrote:
> > This is necessary for a future change I'd like to make (basically,
> > http://codereview.chromium.org/10386108/ for v8).
> > 
> > https://chromiumcodereview.appspot.com/10310156/diff/1/tools/gyp/v8.gyp
> > File tools/gyp/v8.gyp (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10310156/diff/1/tools/gyp/v8.gyp#newco...
> > tools/gyp/v8.gyp:729: 'V8_SHARED',
> > See here.
> 
> Please base the patch on svn/bleeding_edge instead of svn/trunk.

The diff is identical on bleeding_edge (just checked).

[Jakob Kummerow, 2012-05-15 13:55:46]

GYP changes LGTM. 

Yang (thanks!) said he'd test if the defines changes cause any breakage on
Windows.

[Yang, 2012-05-16 15:49:02]

On 2012/05/15 13:55:46, Jakob wrote:
> GYP changes LGTM. 
> 
> Yang (thanks!) said he'd test if the defines changes cause any breakage on
> Windows.

It turns out d8 does not like having USING_V8_SHARED and V8_SHARED set at the
same time. I fixed that in http://codereview.chromium.org/10398057/ and landed
it in r11586.