Issue 10310067: Remove ui-enable-dip option

Issue 10310067: Remove ui-enable-dip option (Closed)

Created:
8 years, 7 months ago by oshima

Modified:
8 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, jonathan.backer, Ian Vollick, dhollowa+watch_chromium.org, ben+watch_chromium.org, piman+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove ui-enable-dip option BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137659

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : sync #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -140 lines)			Patch
M	ash/dip_unittest.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	ui/aura/monitor_change_observer_x11.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/aura/root_window.cc	View	1 2	3 chunks	+12 lines, -24 lines	0 comments	Download
M	ui/compositor/compositor.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/compositor/compositor_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/compositor/compositor_switches.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/compositor/dip_util.h	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	ui/compositor/dip_util.cc	View	1 2	1 chunk	+10 lines, -59 lines	0 comments	Download
M	ui/compositor/layer.cc	View	1 2	6 chunks	+17 lines, -25 lines	0 comments	Download
M	ui/compositor/layer_unittest.cc	View	1 2	4 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

oshima

And this is to remove ui-enable-dip option. Won't land unless branch is officially announced.

8 years, 7 months ago (2012-05-08 20:36:58 UTC) #1

sky

Are you sure you don't want to keep the switch around, but make the default ...

8 years, 7 months ago (2012-05-08 21:11:50 UTC) #2

oshima

On 2012/05/08 21:11:50, sky wrote: > Are you sure you don't want to keep the ...

8 years, 7 months ago (2012-05-08 21:28:57 UTC) #3

sky

8 years, 7 months ago (2012-05-08 21:32:13 UTC) #4

If you're confident it's staying, LGTM.

On Tue, May 8, 2012 at 2:28 PM,  <oshima@chromium.org> wrote:
> On 2012/05/08 21:11:50, sky wrote:
>>
>> Are you sure you don't want to keep the switch around, but make the
>> default be
>> true?
>
>
> DIP code is quite simple now so I believe this is low risk. I'm ok to just
> change the default if you prefer that way though. Let me know.
>
>
> http://codereview.chromium.org/10310067/

Expand Messages | Collapse Messages