Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1949)

Unified Diff: build/android/run_tests.py

Issue 10310046: Detect crashes while running native tests in APK. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/single_test_runner.py » ('j') | build/android/test_package.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/run_tests.py
diff --git a/build/android/run_tests.py b/build/android/run_tests.py
index 1015d2649ea6246df6a1a08170014cd9cca2957f..ca28965b68c51467665262ce38fac834096a9720 100755
--- a/build/android/run_tests.py
+++ b/build/android/run_tests.py
@@ -193,8 +193,8 @@ def RunTests(device, test_suite, gtest_filter, test_arguments, rebaseline,
if test_suite in _TEST_SUITES:
logging.critical('(Remember to include the path: out/Release/%s)',
test_suite)
- return TestResults.FromOkAndFailed([], [BaseTestResult(test_suite, '')],
- False, False)
+ return TestResults.FromOkFailedAndCrashed(
John Grabowski 2012/05/07 19:22:15 Seems a bit verbose now; how about just TestResult
nilesh 2012/05/08 01:38:10 Done.
+ [], [BaseTestResult(test_suite, '')], [], False, False)
fully_qualified_test_suites = [test_suite]
else:
fully_qualified_test_suites = FullyQualifiedTestSuites(apk)
« no previous file with comments | « no previous file | build/android/single_test_runner.py » ('j') | build/android/test_package.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698