Detect crashes while running native tests in APK.

build/android/test_package.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 import logging
 import re
 import os
 import pexpect
 
@@ skipping 111 matching lines @@
         ret += [current + test_name]
     return ret
 
   def _WatchTestOutput(self, p):
     """Watches the test output.
     Args:
       p: the process generating output as created by pexpect.spawn.
     """
     ok_tests = []
     failed_tests = []
+    crashed_tests = []
     timed_out = False
     overall_fail = False
     re_run = re.compile('\[ RUN      \] ?(.*)\r\n')
     # APK tests rely on the END tag.
     re_end = re.compile('\[ END      \] ?(.*)\r\n')
+    re_crash = re.compile('\[ CRASHED      \](.*)\r\n')

[John Grabowski, 2012/05/07 19:22:15]

It seems illogical a test will announce it crashed.
Comments in this file seem apropos.

[nilesh, 2012/05/08 01:38:10]

I am not sure I understand what you want here. Can you please explain a bit
more.

[John Grabowski, 2012/05/08 12:54:10]

Sure.

At first glance it does not make sense that a test can announce it crashed.

At this point in the py code explain how that does in fact work (e.g. catch
signal, print, and exit.)

[nilesh, 2012/05/08 22:18:43]

Done.

     re_fail = re.compile('\[  FAILED  \] ?(.*)\r\n')
     re_runner_fail = re.compile('\[ RUNNER_FAILED \] ?(.*)\r\n')
     re_ok = re.compile('\[       OK \] ?(.*)\r\n')
     (io_stats_before, ready_to_continue) = self._BeginGetIOStats()
     while ready_to_continue:
       found = p.expect([re_run, pexpect.EOF, re_end, re_runner_fail],
                        timeout=self.timeout)
       if found == 1:  # matched pexpect.EOF
         break
       if found == 2:  # matched END.
         break
       if found == 3:  # RUNNER_FAILED
         logging.error('RUNNER_FAILED')
         overall_fail = True
         break
       if self.dump_debug_info:
         self.dump_debug_info.TakeScreenshot('_Test_Start_Run_')
       full_test_name = p.match.group(1)
-      found = p.expect([re_ok, re_fail, pexpect.EOF, pexpect.TIMEOUT],
+      found = p.expect([re_ok, re_fail, re_crash, pexpect.EOF, pexpect.TIMEOUT],
                        timeout=self.timeout)
       if found == 0:  # re_ok
         ok_tests += [BaseTestResult(full_test_name.replace('\r', ''),
                                     p.before)]
         continue
+      if found == 2: # re_crash
+        crashed_tests += [BaseTestResult(full_test_name.replace('\r', ''),
+                                         p.before)]
+        overall_fail = True
+        break
+      # The test failed.
       failed_tests += [BaseTestResult(full_test_name.replace('\r', ''),
                                       p.before)]
-      if found >= 2:
-        # The test crashed / bailed out (i.e., didn't print OK or FAIL).
+      if found >= 3:
+        # The test bailed out (i.e., didn't print OK or FAIL).
         if found == 3:  # pexpect.TIMEOUT
           logging.error('Test terminated after %d second timeout.',
                         self.timeout)
           timed_out = True
         break
     p.close()
     if not self.rebaseline and ready_to_continue:
       ok_tests += self._EndGetIOStats(io_stats_before)
       ret_code = self._GetGTestReturnCode()
       if ret_code:
         failed_tests += [BaseTestResult('gtest exit code: %d' % ret_code,
                                         'pexpect.before: %s'
                                         '\npexpect.after: %s'
                                         % (p.before,
                                            p.after))]
-    return TestResults.FromOkAndFailed(ok_tests, failed_tests,
-                                       timed_out, overall_fail)
+    # Create TestResults and return
+    return TestResults.FromOkFailedAndCrashed(ok_tests, failed_tests,
+                                              crashed_tests, timed_out,
+                                              overall_fail)