Reapply "Changes according to review comments"

ui/base/l10n/l10n_util.cc

Index: ui/base/l10n/l10n_util.cc
diff --git a/ui/base/l10n/l10n_util.cc b/ui/base/l10n/l10n_util.cc
index 6cf460883531f038d5435dcb99117a3b7d56e616..2f402b8468c0e1c0b83babd7fc38a70589c0a280 100644
--- a/ui/base/l10n/l10n_util.cc
+++ b/ui/base/l10n/l10n_util.cc
@@ -10,6 +10,7 @@
 #include <string>
 
 #include "base/command_line.h"
+#include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/i18n/file_util_icu.h"
 #include "base/i18n/rtl.h"
@@ -27,6 +28,10 @@
 #include "unicode/rbbi.h"
 #include "unicode/uloc.h"
 
+#if defined(OS_ANDROID)
+#include "base/android/locale_utils.h"
+#endif
+
 #if defined(OS_LINUX)
 #include <glib.h>
 #endif
@@ -474,26 +479,49 @@ string16 GetDisplayNameForLocale(const std::string& locale,
   // #1 and #2 wouldn't work if display_locale != current UI locale although
   // we can think of additional hack to work around the problem.
   // #3 can be potentially expensive.
-  if (locale_code == "zh-CN")
+  bool is_zh ALLOW_UNUSED = false;
+  if (locale_code == "zh-CN") {
     locale_code = "zh-Hans";
-  else if (locale_code == "zh-TW")
+    is_zh = true;
+  } else if (locale_code == "zh-TW") {
     locale_code = "zh-Hant";
-
-  UErrorCode error = U_ZERO_ERROR;
-  const int kBufferSize = 1024;
+    is_zh = true;
+  }
 
   string16 display_name;
-  int actual_size = uloc_getDisplayName(locale_code.c_str(),
-      display_locale.c_str(),
-      WriteInto(&display_name, kBufferSize), kBufferSize - 1, &error);
-  DCHECK(U_SUCCESS(error));
-  display_name.resize(actual_size);
+#if defined(OS_ANDROID)
+  // Use Java API to get locale display name so that we can remove most of
+  // the lang data from icu data to reduce binary size, except for zh-Hans and
+  // zh-Hant because the current Android Java API doesn't support scripts.
+  // TODO(wangxianzhu): remove the special handling of zh-Hans and zh-Hant once
+  // Android Java API supports scripts.
+  if (!is_zh) {

[Ilya Sherman, 2012/05/05 00:42:03]

nit: Would it be equivalent to check that the locale_code starts with "zh"?  If
so, that would be a little simpler.

[Xianzhu, 2012/05/05 01:03:53]

Changed to use StartsWithASCII(locale_code, "zh-Han", true) to avoid is_zh.

+    display_name = base::android::GetDisplayNameForLocale(locale_code,
+                                                          display_locale);
+  } else
+#endif
+  {
+    UErrorCode error = U_ZERO_ERROR;
+    const int kBufferSize = 1024;
+
+    int actual_size = uloc_getDisplayName(locale_code.c_str(),
+        display_locale.c_str(),
+        WriteInto(&display_name, kBufferSize), kBufferSize - 1, &error);
+    DCHECK(U_SUCCESS(error));
+    display_name.resize(actual_size);
+  }
+
   // Add an RTL mark so parentheses are properly placed.
   if (is_for_ui && base::i18n::IsRTL())
     display_name.push_back(static_cast<char16>(base::i18n::kRightToLeftMark));
   return display_name;
 }
 
+string16 GetDisplayNameForCountry(const std::string& country_code,
+                                  const std::string& display_locale) {
+  return GetDisplayNameForLocale("_" + country_code, display_locale, false);
+}
+
 std::string NormalizeLocale(const std::string& locale) {
   std::string normalized_locale(locale);
   std::replace(normalized_locale.begin(), normalized_locale.end(), '-', '_');