Reapply "Changes according to review comments"

Reapply "Changes according to review comments"

Fixed an "unused variable" issue of the original CL (http://codereview.chromium.org/10224004/).

Use Android API for GetDisplayNameForLocale().

Using Android API, we can reduce the data size of ICU and thus reduce the
binary size of chromium-android.

BUG=none
TEST=L10nUtilTest.GetDisplayNameForLocale,L10nUtilTest.GetDisplayNameForCountry
TBR=jrg@chromium.org,isherman@chromium.org,mark@chromium.org,jshin@chromium.org,rvargas@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135524

[commit-bot: I haz the power, 2012-05-05 00:24:44]

No comments yet.

[Xianzhu, 2012-05-05 00:36:49]

LGTM (is this allowed?)

[Xianzhu, 2012-05-05 00:39:43]

Hi, reviewers, this CL needs one LGTM from you to be committed. The only change
to the original CL is the added ALLOW_USED to the is_zh variable in
l10n_util.cc.

Thanks.

[commit-bot: I haz the power, 2012-05-05 00:40:30]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Ilya Sherman, 2012-05-05 00:42:03]

LGTM

http://codereview.chromium.org/10310029/diff/1/ui/base/l10n/l10n_util.cc
File ui/base/l10n/l10n_util.cc (right):

http://codereview.chromium.org/10310029/diff/1/ui/base/l10n/l10n_util.cc#newc...
ui/base/l10n/l10n_util.cc:498: if (!is_zh) {
nit: Would it be equivalent to check that the locale_code starts with "zh"?  If
so, that would be a little simpler.

[Xianzhu, 2012-05-05 01:03:51]

http://codereview.chromium.org/10310029/diff/1/ui/base/l10n/l10n_util.cc
File ui/base/l10n/l10n_util.cc (right):

http://codereview.chromium.org/10310029/diff/1/ui/base/l10n/l10n_util.cc#newc...
ui/base/l10n/l10n_util.cc:498: if (!is_zh) {
On 2012/05/05 00:42:03, Ilya Sherman wrote:
> nit: Would it be equivalent to check that the locale_code starts with "zh"? 
If
> so, that would be a little simpler.

Changed to use StartsWithASCII(locale_code, "zh-Han", true) to avoid is_zh.

[commit-bot: I haz the power, 2012-05-05 01:04:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10310029/4002

[commit-bot: I haz the power, 2012-05-05 03:11:46]

Change committed as 135524