Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6465)

Unified Diff: chrome/renderer/resources/extensions/web_request_custom_bindings.js

Issue 10310028: Making webRequest.addEventListener internal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implicit internal permissions for webRequest Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/web_request_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/web_request_custom_bindings.js b/chrome/renderer/resources/extensions/web_request_custom_bindings.js
index a0e00e85efd2592a34f0f7cd84be2a57f65f0bb6..70b4a120fbdbd31b17046188cc632991b995ad85 100644
--- a/chrome/renderer/resources/extensions/web_request_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/web_request_custom_bindings.js
@@ -64,7 +64,7 @@ WebRequestEvent.prototype.addListener =
// subEvent listener.
chromeHidden.validate(Array.prototype.slice.call(arguments, 1),
this.extraArgSchemas_);
- chrome.webRequest.addEventListener(
+ chromeHidden.internalAPIs.webRequestInternal.addEventListener(
cb, opt_filter, opt_extraInfo, this.eventName_, subEventName);
var subEvent = new chrome.Event(subEventName, this.argSchemas_);
@@ -152,19 +152,23 @@ chromeHidden.registerCustomEvent('webRequest', WebRequestEvent);
chromeHidden.registerCustomHook('webRequest', function(api) {
var apiFunctions = api.apiFunctions;
- apiFunctions.setHandleRequest('addEventListener', function() {
+ apiFunctions.setHandleRequest('eventHandled', function() {
var args = Array.prototype.slice.call(arguments);
sendRequest(this.name, args, this.definition.parameters,
{forIOThread: true});
});
- apiFunctions.setHandleRequest('eventHandled', function() {
+ apiFunctions.setHandleRequest('handlerBehaviorChanged', function() {
var args = Array.prototype.slice.call(arguments);
sendRequest(this.name, args, this.definition.parameters,
{forIOThread: true});
});
+});
- apiFunctions.setHandleRequest('handlerBehaviorChanged', function() {
+chromeHidden.registerCustomHook('webRequestInternal', function(api) {
battre 2012/05/15 09:23:38 I think this should go into web_request_internal_c
vabr (Chromium) 2012/05/15 11:57:52 Done.
+ var apiFunctions = api.apiFunctions;
+
+ apiFunctions.setHandleRequest('addEventListener', function() {
var args = Array.prototype.slice.call(arguments);
sendRequest(this.name, args, this.definition.parameters,
{forIOThread: true});

Powered by Google App Engine
This is Rietveld 408576698