Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Unified Diff: net/socket/tcp_client_socket_unittest.cc

Issue 10309002: Reimplements net::AddressList without struct addrinfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added missing NET_EXPORT to *PortOnAddressList. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/tcp_client_socket_unittest.cc
diff --git a/net/socket/tcp_client_socket_unittest.cc b/net/socket/tcp_client_socket_unittest.cc
index 991b645bb9cb3b27fbeeceeaa88a8e8545752cf6..12a46d438b904baa96ee2c990530cc6431b8b221 100644
--- a/net/socket/tcp_client_socket_unittest.cc
+++ b/net/socket/tcp_client_socket_unittest.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -11,7 +11,6 @@
#include "net/base/ip_endpoint.h"
#include "net/base/net_errors.h"
#include "net/base/net_util.h"
-#include "net/base/sys_addrinfo.h"
#include "net/base/test_completion_callback.h"
#include "net/socket/tcp_server_socket.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -32,8 +31,7 @@ TEST(TCPClientSocketTest, BindLoopbackToLoopback) {
ASSERT_EQ(OK, server.GetLocalAddress(&server_address));
TCPClientSocket socket(
- AddressList::CreateFromIPAddress(server_address.address(),
- server_address.port()),
+ AddressList(server_address),
eroman 2012/05/04 01:08:41 Fits on one line now.
NULL, NetLog::Source());
EXPECT_EQ(OK, socket.Bind(IPEndPoint(lo_address, 0)));
@@ -89,8 +87,7 @@ TEST(TCPClientSocketTest, BindLoopbackToIPv6) {
IPEndPoint server_address;
ASSERT_EQ(OK, server.GetLocalAddress(&server_address));
TCPClientSocket socket(
- AddressList::CreateFromIPAddress(server_address.address(),
- server_address.port()),
+ AddressList(server_address),
eroman 2012/05/04 01:08:41 One line dude.
NULL, NetLog::Source());
IPAddressNumber ipv4_lo_ip;

Powered by Google App Engine
This is Rietveld 408576698