Reimplements net::AddressList without struct addrinfo.

net/dns/dns_response_unittest.cc

Index: net/dns/dns_response_unittest.cc
diff --git a/net/dns/dns_response_unittest.cc b/net/dns/dns_response_unittest.cc
index 1861f10b47fb2f167635aceb9546e4a97403841e..2e3ff253783089f6701533e20a2e57c12ecef226 100644
--- a/net/dns/dns_response_unittest.cc
+++ b/net/dns/dns_response_unittest.cc
@@ -8,7 +8,6 @@
 #include "net/base/address_list.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_util.h"
-#include "net/base/sys_addrinfo.h"
 #include "net/dns/dns_protocol.h"
 #include "net/dns/dns_query.h"
 #include "net/dns/dns_test_util.h"
@@ -248,21 +247,11 @@ TEST(DnsResponseTest, InitParse) {
 
 void VerifyAddressList(const std::vector<const char*>& ip_addresses,
                        const AddressList& addrlist) {
-  ASSERT_GT(ip_addresses.size(), 0u);
-  ASSERT_NE(static_cast<addrinfo*>(NULL), addrlist.head());
-
-  IPAddressNumber ip_number;
-  const struct addrinfo* ainfo = addrlist.head();
-  for (std::vector<const char*>::const_iterator i = ip_addresses.begin();
-       i != ip_addresses.end(); ++i, ainfo = ainfo->ai_next) {
-    ASSERT_NE(static_cast<addrinfo*>(NULL), ainfo);
-    EXPECT_EQ(sizeof(struct sockaddr_in),
-              static_cast<size_t>(ainfo->ai_addrlen));
-
-    const struct sockaddr* sa = ainfo->ai_addr;
-    EXPECT_STREQ(*i, NetAddressToString(sa, ainfo->ai_addrlen).c_str());
+  ASSERT_EQ(ip_addresses.size(), addrlist.size());
+
+  for (size_t i = 0; i < addrlist.size(); ++i) {

[eroman, 2012/05/04 01:08:41]

[optional] nit: this is inconsistent with the other locations which use
iterators. I don't care either way, my preference is  to use size_t throughout.

[szym, 2012/05/04 02:38:29]

I defaulted to const_iterator where a while loop was used. I'll probably convert
those other places to size_t i for shortness. 

+    EXPECT_EQ(ip_addresses[i], addrlist[i].ToStringWithoutPort());
   }
-  ASSERT_EQ(static_cast<addrinfo*>(NULL), ainfo);
 }
 
 TEST(DnsResponseTest, ParseToAddressList) {
@@ -316,9 +305,7 @@ TEST(DnsResponseTest, ParseToAddressList) {
         t.expected_addresses,
         t.expected_addresses + t.num_expected_addresses);
     VerifyAddressList(expected_addresses, addr_list);
-    std::string cname;
-    ASSERT_TRUE(addr_list.GetCanonicalName(&cname));
-    EXPECT_EQ(t.expected_cname, cname);
+    EXPECT_EQ(t.expected_cname, addr_list.get_canonical_name());
     EXPECT_EQ(base::TimeDelta::FromSeconds(t.expected_ttl_sec), ttl);
   }
 }