chrome/browser/net/network_stats.h - Issue 10309002: Reimplements net::AddressList without struct addrinfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/network_stats.h

Issue 10309002: Reimplements net::AddressList without struct addrinfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added missing NET_EXPORT to *PortOnAddressList. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/network_stats.h

diff --git a/chrome/browser/net/network_stats.h b/chrome/browser/net/network_stats.h

index 8425c3614bc5fe27b1e4496241f4dfaa56479a9d..ec1e455cae2ebfeccd90e4ea6140f335df54f1a6 100644

--- a/chrome/browser/net/network_stats.h

+++ b/chrome/browser/net/network_stats.h

@@ -149,7 +149,7 @@ class NetworkStats {

base::TimeTicks start_time() const { return start_time_; }

// Returns |addresses_|.

- net::AddressList GetAddressList() const { return addresses_; }

+ const net::AddressList& GetAddressList() const { return addresses_; }

eroman 2012/05/04 01:08:41 might want to add a TODO to rename this to address

szym 2012/05/04 05:27:55 Actually, renamed to get_address_list (only used i

// Collect the following network connectivity stats.

// a) What percentage of users can get a message end-to-end to a TCP/UDP