Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp

Issue 10309002: Reimplements net::AddressList without struct addrinfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: get_canonical_name -> canonical_name. iterator to indexing Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
diff --git a/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp b/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
index 56565fceaf77c39f23ae6b4f86b30f5eacfed25e..c161b65d8523ecddc748cce013d9c49a27638605 100644
--- a/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
+++ b/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
@@ -51,6 +51,7 @@
#include "chrome/common/net/x509_certificate_model.h"
#include "crypto/scoped_nss_types.h"
#include "grit/generated_resources.h"
+#include "net/base/ip_endpoint.h"
#include "net/base/net_util.h"
#include "net/third_party/mozilla_security_manager/nsNSSCertTrust.h"
#include "ui/base/l10n/l10n_util.h"
@@ -528,26 +529,10 @@ std::string ProcessGeneralName(PRArenaPool* arena,
break;
case certIPAddress: {
key = l10n_util::GetStringUTF8(IDS_CERT_GENERAL_NAME_IP_ADDRESS);
- struct addrinfo addr = {0};
- if (current->name.other.len == 4) {
- struct sockaddr_in addr4 = {0};
- addr.ai_addr = reinterpret_cast<sockaddr*>(&addr4);
- addr.ai_addrlen = sizeof(addr4);
- addr.ai_family = AF_INET;
- addr4.sin_family = addr.ai_family;
- memcpy(&addr4.sin_addr, current->name.other.data,
- current->name.other.len);
- value = net::NetAddressToString(&addr);
- } else if (current->name.other.len == 16) {
- struct sockaddr_in6 addr6 = {0};
- addr.ai_addr = reinterpret_cast<sockaddr*>(&addr6);
- addr.ai_addrlen = sizeof(addr6);
- addr.ai_family = AF_INET6;
- addr6.sin6_family = addr.ai_family;
- memcpy(&addr6.sin6_addr, current->name.other.data,
- current->name.other.len);
- value = net::NetAddressToString(&addr);
- }
+ net::IPAddressNumber ip(
+ current->name.other.data,
+ current->name.other.data + current->name.other.len);
+ value = net::IPEndPoint(ip, 0).ToStringWithoutPort();
if (value.empty()) {
// Invalid IP address.
value = ProcessRawBytes(&current->name.other);
« no previous file with comments | « chrome/browser/ui/webui/net_internals/net_internals_ui.cc ('k') | content/browser/renderer_host/p2p/socket_dispatcher_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698