Reimplements net::AddressList without struct addrinfo.

chrome/browser/net/network_stats.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NET_NETWORK_STATS_H_
 #define CHROME_BROWSER_NET_NETWORK_STATS_H_
 #pragma once
 
 #include <string>
 
@@ skipping 133 matching lines @@
   uint32 load_size() const { return load_size_; }
 
   // Helper methods to get and set |socket_|.
   net::Socket* socket() { return socket_.get(); }
   void set_socket(net::Socket* socket);
 
   // Returns |start_time_| (used by histograms).
   base::TimeTicks start_time() const { return start_time_; }
 
   // Returns |addresses_|.
-  net::AddressList GetAddressList() const { return addresses_; }
+  const net::AddressList& get_address_list() const { return addresses_; }

[eroman, 2012/05/04 19:37:36]

Why not call this addresses()?

our hacker style for accessors is to name it the same as the private variable
(without the trailing underscore). For setters you prefix with "set_". See for
instance the other accessors in this header: "load_size(), "start_time".

[szym, 2012/05/04 20:20:21]

Of course! Wasn't thinking.

 
   // Returns packets_received_mask_ (used by unit tests).
   uint32 packets_received_mask() const { return packets_received_mask_; }
 
   // Collect the following network connectivity stats.
   // a) What percentage of users can get a message end-to-end to a TCP/UDP
   // server and if connectivity failed, at what stage (Connect or Write or Read)
   // did it fail?
   // b) What is RTT for the echo message.
   void RecordHistograms(const ProtocolValue& protocol,
@@ skipping 186 matching lines @@
 // This collects the network connectivity stats for UDP and TCP for small
 // percentage of users who are participating in the experiment. All users must
 // have enabled "UMA upload". This method gets called only if UMA upload to the
 // server has succeeded.
 void CollectNetworkStats(const std::string& network_stats_server_url,
                          IOThread* io_thread);
 
 }  // namespace chrome_browser_net
 
 #endif  // CHROME_BROWSER_NET_NETWORK_STATS_H_