Reimplements net::AddressList without struct addrinfo.

net/base/host_resolver_proc.h

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_HOST_RESOLVER_PROC_H_
 #define NET_BASE_HOST_RESOLVER_PROC_H_
 #pragma once
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
 #include "net/base/address_family.h"
 #include "net/base/net_export.h"
 
 namespace net {
 
 class AddressList;
 
+// Sets the port on each element in |list| to |port|.
+void NET_EXPORT SetPortOnAddressList(uint16 port, AddressList* list);

[eroman, 2012/05/04 01:08:41]

This doesn't feel like the right place to house this code.

Maybe address_list.h would be a better fit for this first function. The second
function is a little bit too specific on how the lists were constructed, so
doesn't fit as cleanly into address_list.h

This is probably more appropriate in address_list.h, or part of
host_resolver_impl.cc which is where it is used. (who else uses this?)

I dunno; net_util.h ends up being our dumping ground for these sorts of things.

[szym, 2012/05/04 02:38:29]

Only HostResolver-related code uses this, but this includes
mock_host_resolver.cc
On the other hand, there is little benefit from such optimization in
MockHostResolver, so I'll move EnsurePort... to host_resolver_impl.cc and
SetPort... to address_list.cc

[eroman, 2012/05/04 04:20:22]

Sounds like a good plan.

+
+// As above, but skips work if first port on |list| matches |port|.
+void NET_EXPORT EnsurePortOnAddressList(uint16 port, AddressList* list);
+
 // Interface for a getaddrinfo()-like procedure. This is used by unit-tests
 // to control the underlying resolutions in HostResolverImpl. HostResolverProcs
 // can be chained together; they fallback to the next procedure in the chain
 // by calling ResolveUsingPrevious().
 //
 // Note that implementations of HostResolverProc *MUST BE THREADSAFE*, since
 // the HostResolver implementation using them can be multi-threaded.
 class NET_EXPORT HostResolverProc
     : public base::RefCountedThreadSafe<HostResolverProc> {
  public:
@@ skipping 59 matching lines @@
 NET_EXPORT_PRIVATE int SystemHostResolverProc(
     const std::string& host,
     AddressFamily address_family,
     HostResolverFlags host_resolver_flags,
     AddressList* addrlist,
     int* os_error);
 
 }  // namespace net
 
 #endif  // NET_BASE_HOST_RESOLVER_PROC_H_