Reimplements net::AddressList without struct addrinfo.

content/browser/renderer_host/p2p/socket_dispatcher_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/p2p/socket_dispatcher_host.h"
 
 #include "base/bind.h"
 #include "base/stl_util.h"
 #include "content/browser/renderer_host/p2p/socket_host.h"
 #include "content/public/browser/resource_context.h"
@@ skipping 54 matching lines @@
 
  private:
   void OnDone(int result) {
     if (result != net::OK) {
       LOG(ERROR) << "Failed to resolve address for " << host_name_
                  << ", errorcode: " << result;
       done_callback_.Run(net::IPAddressNumber());
       return;
     }
 
-    if (addresses_.head() == NULL) {
+    if (addresses_.empty()) {

[eroman, 2012/05/04 01:08:41]

Yuck.

I am surprised to keep seeing these checks...

HostResolver returns an error when it fails to resolve. The API specification is
pretty ambiguous about what the result is in this case (it only says it is set
on success). Feels like a bit of an abuse for code to be relying on this
pattern.

Actually in this case it seems like this check is unnecessary, I see no reason
why HostResolver would return an empty result on success. In fact maybe that
should specifically be part of the contract do avoid these sorts of checks all
over the place.

       LOG(ERROR) << "Received 0 addresses when trying to resolve address for "
                  << host_name_;
       done_callback_.Run(net::IPAddressNumber());
       return;
     }
 
-    net::IPEndPoint end_point;
-    if (!end_point.FromSockAddr(addresses_.head()->ai_addr,
-                                addresses_.head()->ai_addrlen)) {
-      LOG(ERROR) << "Received invalid address for " << host_name_;
-      done_callback_.Run(net::IPAddressNumber());
-      return;
-    }
-
-    done_callback_.Run(end_point.address());
+    done_callback_.Run(addresses_.front().address());
   }
 
   int32 routing_id_;
   int32 request_id_;
   net::AddressList addresses_;
 
   std::string host_name_;
   net::SingleRequestHostResolver resolver_;
 
   DoneCallback done_callback_;
@@ skipping 179 matching lines @@
     DnsRequest* request,
     const net::IPAddressNumber& result) {
   Send(new P2PMsg_GetHostAddressResult(
       request->routing_id(), request->request_id(), result));
 
   dns_requests_.erase(request);
   delete request;
 }
 
 }  // namespace content