Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6911)

Unified Diff: chrome/common/chrome_paths_win.cc

Issue 10306009: Make sure only the main browser process and service proceses are allowed to create the profile dire… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/chrome_paths.cc ('K') | « chrome/common/chrome_paths_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_paths_win.cc
diff --git a/chrome/common/chrome_paths_win.cc b/chrome/common/chrome_paths_win.cc
index 5eefb78f6250e1b29d4870b750c48ab13ff31218..6a692a98cee16a4916c2f83c962227b53a031039 100644
--- a/chrome/common/chrome_paths_win.cc
+++ b/chrome/common/chrome_paths_win.cc
@@ -17,6 +17,13 @@
#include "chrome/common/chrome_constants.h"
#include "chrome/installer/util/browser_distribution.h"
+namespace {
+// TODO(pastarmovj): Remove this copy of kServiceProcess once we get
+// better way to share constants between content and chrome. Using content
+// switches makes all hell break loose on us when linking.
+const char kServiceProcess[] = "service";
+}
+
namespace chrome {
bool GetDefaultUserDataDirectory(FilePath* result) {
@@ -97,4 +104,11 @@ bool GetUserDesktop(FilePath* result) {
return true;
}
+bool ProcessNeedsProfileDir(const std::string& process_type) {
+ // On windows we don't want subprocesses other than the browser process and
+ // service processes to be able to use the profile directory because if it
+ // lies on a network share the sandbox will prevent us from accessing it.
+ return process_type.empty() || process_type == kServiceProcess;
+}
+
} // namespace chrome
« chrome/common/chrome_paths.cc ('K') | « chrome/common/chrome_paths_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698