Make sure only the main browser process and service proceses are allowed to create the profile dire…

base/path_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_PATH_SERVICE_H_
 #define BASE_PATH_SERVICE_H_
 #pragma once
 
 #include <string>
 
@@ skipping 22 matching lines @@
   // path specifies a directory that does not exist, the directory will be
   // created by this method.  This method returns true if successful.
   //
   // If the given path is relative, then it will be resolved against
   // DIR_CURRENT.
   //
   // WARNING: Consumers of PathService::Get may expect paths to be constant
   // over the lifetime of the app, so this method should be used with caution.
   static bool Override(int key, const FilePath& path);
 
+  // Overrides the path to a special directory or file.  This cannot be used to

[willchan no longer on Chromium, 2012/05/02 17:42:34]

Rather than copying the comment from above, how about just saying it's the same
except for the |create| stuff, which you should explain?

Also, it seems like this API subsumes the other one. Maybe we should eliminate
the overlap and just create a OverrideButDontCreate()? Sounds ugly. I guess I
prefer what you currently have. Was just a thought.

[pastarmovj, 2012/05/03 16:48:24]

Done.

+  // change the value of DIR_CURRENT, but that should be obvious.  Also, if the
+  // path specifies a directory that does not exist, the directory will be
+  // created if the |create| flag is set to true.  This method returns true if
+  // successful.
+  //
+  // If the given path is relative, then it will be resolved against
+  // DIR_CURRENT.
+  //
+  // WARNING: Consumers of PathService::Get may expect paths to be constant
+  // over the lifetime of the app, so this method should be used with caution.
+  static bool OverrideAndCreateIfNeeded(int key,
+                                        const FilePath& path,
+                                        bool create);
+
   // To extend the set of supported keys, you can register a path provider,
   // which is just a function mirroring PathService::Get.  The ProviderFunc
   // returns false if it cannot provide a non-empty path for the given key.
   // Otherwise, true is returned.
   //
   // WARNING: This function could be called on any thread from which the
   // PathService is used, so a the ProviderFunc MUST BE THREADSAFE.
   //
   typedef bool (*ProviderFunc)(int, FilePath*);
 
   // Call to register a path provider.  You must specify the range "[key_start,
   // key_end)" of supported path keys.
   static void RegisterProvider(ProviderFunc provider,
                                int key_start,
                                int key_end);
  private:
   static bool GetFromCache(int key, FilePath* path);
   static bool GetFromOverrides(int key, FilePath* path);
   static void AddToCache(int key, const FilePath& path);
 };
 
 #endif  // BASE_PATH_SERVICE_H_