Check that the renderer can access files it claims are part of a drag.

Check that the renderer can access files it claims are part of a drag.

BUG=123054
TEST=manual that nothing broke


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135252

[dcheng, 2012-05-03 02:00:24]

Ideally it'd be nice to have something like webkit/glue/drag_client.h and have
content implement the interface to do the checking. I'm not sure how this would
be structured though--at the point where we get a WebDropData, we're still
running inside the renderer so we can't do security checks there...

[Charlie Reis, 2012-05-03 18:12:10]

I'm probably not a good reviewer for this code, since I'm not familiar with any
of the drag and drop logic.  It seems odd to me that this only changes Aura, but
perhaps I don't understand what the problem was.

[jam, 2012-05-03 18:24:14]

I second Charlie's comment about other platforms?

[dcheng, 2012-05-03 18:54:39]

This problem only exists on aura today. However, I thought about it more last
night and I think I have a better version of this patch that will keep other
platforms safe is File drag out is implemented on them as well.

[Charlie Reis, 2012-05-03 20:02:06]

That seems much better.  The comment helps as well.  LGTM.

[dcheng, 2012-05-03 20:10:25]

+sky for OWNERS approval.

[dcheng, 2012-05-03 20:10:25]

+sky for OWNERS approval.

[sky, 2012-05-03 21:07:02]

http://codereview.chromium.org/10302006/diff/4001/content/browser/renderer_ho...
File content/browser/renderer_host/render_view_host_impl.cc (right):

http://codereview.chromium.org/10302006/diff/4001/content/browser/renderer_ho...
content/browser/renderer_host/render_view_host_impl.cc:1360:
view->StartDragging(filtered_data, drag_operations_mask, image, image_offset);
What happens if you end up here and everything was filtered?

[dcheng, 2012-05-03 21:14:49]

http://codereview.chromium.org/10302006/diff/4001/content/browser/renderer_ho...
File content/browser/renderer_host/render_view_host_impl.cc (right):

http://codereview.chromium.org/10302006/diff/4001/content/browser/renderer_ho...
content/browser/renderer_host/render_view_host_impl.cc:1360:
view->StartDragging(filtered_data, drag_operations_mask, image, image_offset);
On 2012/05/03 21:07:05, sky wrote:
> What happens if you end up here and everything was filtered?

We'll start a drag but there won't be any data contained in the drag. I think
this is OK, as you could legitimately have a situation where this occurs.

[sky, 2012-05-03 21:30:49]

LGTM

[commit-bot: I haz the power, 2012-05-03 21:35:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/10302006/4001

[commit-bot: I haz the power, 2012-05-04 00:24:59]

Change committed as 135252