Stop refcounting URLRequestContext.

webkit/fileapi/file_system_operation_write_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // NOTE: These tests are run as part of "unit_tests" (in chrome/test/unit)
 // rather than as part of test_shell_tests because they rely on being able
 // to instantiate a MessageLoop of type TYPE_IO.  test_shell_tests uses
 // TYPE_UI, which URLRequest doesn't allow.
 //
 
@@ skipping 136 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(FileSystemOperationWriteTest);
 };
 
 namespace {
 
 class TestURLRequestContext : public net::URLRequestContext {
  public:
   TestURLRequestContext()
       : blob_storage_controller_(new webkit_blob::BlobStorageController) {}
 
+  virtual ~TestURLRequestContext() {}
+
   webkit_blob::BlobStorageController* blob_storage_controller() const {
     return blob_storage_controller_.get();
   }
 
- protected:
-  virtual ~TestURLRequestContext() {}
-
  private:
   scoped_ptr<webkit_blob::BlobStorageController> blob_storage_controller_;
 };
 
 static net::URLRequestJob* BlobURLRequestJobFactory(net::URLRequest* request,
                                                     const std::string& scheme) {
   webkit_blob::BlobStorageController* blob_storage_controller =
       static_cast<const TestURLRequestContext*>(request->context())->
           blob_storage_controller();
   return new webkit_blob::BlobURLRequestJob(
@@ skipping 30 matching lines @@
 
 FileSystemOperation* FileSystemOperationWriteTest::operation() {
   return test_helper_.NewOperation();
 }
 
 TEST_F(FileSystemOperationWriteTest, TestWriteSuccess) {
   GURL blob_url("blob:success");
   scoped_refptr<webkit_blob::BlobData> blob_data(new webkit_blob::BlobData());
   blob_data->AppendData("Hello, world!\n");
 
-  scoped_refptr<TestURLRequestContext> url_request_context(
-      new TestURLRequestContext());
-  url_request_context->blob_storage_controller()->AddFinishedBlob(
+  TestURLRequestContext url_request_context;
+  url_request_context.blob_storage_controller()->AddFinishedBlob(
       blob_url, blob_data);
 
-  operation()->Write(url_request_context, URLForPath(virtual_path_), blob_url,
+  operation()->Write(&url_request_context, URLForPath(virtual_path_), blob_url,
                      0, RecordWriteCallback());
   MessageLoop::current()->Run();
 
-  url_request_context->blob_storage_controller()->RemoveBlob(blob_url);
+  url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   EXPECT_EQ(14, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_OK, status());
   EXPECT_TRUE(complete());
 }
 
 TEST_F(FileSystemOperationWriteTest, TestWriteZero) {
   GURL blob_url("blob:zero");
   scoped_refptr<webkit_blob::BlobData> blob_data(new webkit_blob::BlobData());
   blob_data->AppendData("");
 
-  scoped_refptr<TestURLRequestContext> url_request_context(
-      new TestURLRequestContext());
-  url_request_context->blob_storage_controller()->AddFinishedBlob(
+  TestURLRequestContext url_request_context;
+  url_request_context.blob_storage_controller()->AddFinishedBlob(
       blob_url, blob_data);
 
-  operation()->Write(url_request_context, URLForPath(virtual_path_),
+  operation()->Write(&url_request_context, URLForPath(virtual_path_),
                      blob_url, 0, RecordWriteCallback());
   MessageLoop::current()->Run();
 
-  url_request_context->blob_storage_controller()->RemoveBlob(blob_url);
+  url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   EXPECT_EQ(0, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_OK, status());
   EXPECT_TRUE(complete());
 }
 
 TEST_F(FileSystemOperationWriteTest, TestWriteInvalidBlobUrl) {
-  scoped_refptr<TestURLRequestContext> url_request_context(
-      new TestURLRequestContext());
+  TestURLRequestContext url_request_context;
 
-  operation()->Write(url_request_context, URLForPath(virtual_path_),
+  operation()->Write(&url_request_context, URLForPath(virtual_path_),
       GURL("blob:invalid"), 0, RecordWriteCallback());
   MessageLoop::current()->Run();
 
   EXPECT_EQ(0, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_FAILED, status());
   EXPECT_TRUE(complete());
 }
 
 TEST_F(FileSystemOperationWriteTest, TestWriteInvalidFile) {
   GURL blob_url("blob:writeinvalidfile");
   scoped_refptr<webkit_blob::BlobData> blob_data(new webkit_blob::BlobData());
   blob_data->AppendData("It\'ll not be written.");
 
-  scoped_refptr<TestURLRequestContext> url_request_context(
-      new TestURLRequestContext());
-  url_request_context->blob_storage_controller()->AddFinishedBlob(
+  TestURLRequestContext url_request_context;
+  url_request_context.blob_storage_controller()->AddFinishedBlob(
       blob_url, blob_data);
 
-  operation()->Write(url_request_context,
+  operation()->Write(&url_request_context,
                      URLForPath(FilePath(FILE_PATH_LITERAL("nonexist"))),
                      blob_url, 0, RecordWriteCallback());
   MessageLoop::current()->Run();
 
-  url_request_context->blob_storage_controller()->RemoveBlob(blob_url);
+  url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   EXPECT_EQ(0, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_NOT_FOUND, status());
   EXPECT_TRUE(complete());
 }
 
 TEST_F(FileSystemOperationWriteTest, TestWriteDir) {
   FilePath subdir;
   ASSERT_TRUE(file_util::CreateTemporaryDirInDir(filesystem_dir_,
                                                  FILE_PATH_LITERAL("d"),
                                                  &subdir));
   FilePath virtual_subdir_path = subdir.BaseName();
 
   GURL blob_url("blob:writedir");
   scoped_refptr<webkit_blob::BlobData> blob_data(new webkit_blob::BlobData());
   blob_data->AppendData("It\'ll not be written, too.");
 
-  scoped_refptr<TestURLRequestContext> url_request_context(
-      new TestURLRequestContext());
-  url_request_context->blob_storage_controller()->AddFinishedBlob(
+  TestURLRequestContext url_request_context;
+  url_request_context.blob_storage_controller()->AddFinishedBlob(
       blob_url, blob_data);
 
-  operation()->Write(url_request_context, URLForPath(virtual_subdir_path),
+  operation()->Write(&url_request_context, URLForPath(virtual_subdir_path),
                      blob_url, 0, RecordWriteCallback());
   MessageLoop::current()->Run();
 
-  url_request_context->blob_storage_controller()->RemoveBlob(blob_url);
+  url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   EXPECT_EQ(0, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_ACCESS_DENIED, status());
   EXPECT_TRUE(complete());
 }
 
 TEST_F(FileSystemOperationWriteTest, TestWriteFailureByQuota) {
   GURL blob_url("blob:success");
   scoped_refptr<webkit_blob::BlobData> blob_data(new webkit_blob::BlobData());
   blob_data->AppendData("Hello, world!\n");
 
-  scoped_refptr<TestURLRequestContext> url_request_context(
-      new TestURLRequestContext());
-  url_request_context->blob_storage_controller()->AddFinishedBlob(
+  TestURLRequestContext url_request_context;
+  url_request_context.blob_storage_controller()->AddFinishedBlob(
       blob_url, blob_data);
 
   quota_manager_->set_quota(10);
-  operation()->Write(url_request_context, URLForPath(virtual_path_), blob_url,
+  operation()->Write(&url_request_context, URLForPath(virtual_path_), blob_url,
                      0, RecordWriteCallback());
   MessageLoop::current()->Run();
 
-  url_request_context->blob_storage_controller()->RemoveBlob(blob_url);
+  url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   EXPECT_EQ(10, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_NO_SPACE, status());
   EXPECT_TRUE(complete());
 }
 
 TEST_F(FileSystemOperationWriteTest, TestImmediateCancelSuccessfulWrite) {
   GURL blob_url("blob:success");
   scoped_refptr<webkit_blob::BlobData> blob_data(new webkit_blob::BlobData());
   blob_data->AppendData("Hello, world!\n");
 
-  scoped_refptr<TestURLRequestContext> url_request_context(
-      new TestURLRequestContext());
-  url_request_context->blob_storage_controller()->AddFinishedBlob(
+  TestURLRequestContext url_request_context;
+  url_request_context.blob_storage_controller()->AddFinishedBlob(
       blob_url, blob_data);
 
   FileSystemOperationInterface* write_operation = operation();
-  write_operation->Write(url_request_context, URLForPath(virtual_path_),
+  write_operation->Write(&url_request_context, URLForPath(virtual_path_),
                          blob_url, 0, RecordWriteCallback());
   write_operation->Cancel(RecordCancelCallback());
   // We use RunAllPendings() instead of Run() here, because we won't dispatch
   // callbacks after Cancel() is issued (so no chance to Quit) nor do we need
   // to run another write cycle.
   MessageLoop::current()->RunAllPending();
 
-  url_request_context->blob_storage_controller()->RemoveBlob(blob_url);
+  url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   // Issued Cancel() before receiving any response from Write(),
   // so nothing should have happen.
   EXPECT_EQ(0, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_ABORT, status());
   EXPECT_EQ(base::PLATFORM_FILE_OK, cancel_status());
   EXPECT_TRUE(complete());
 }
 
 TEST_F(FileSystemOperationWriteTest, TestImmediateCancelFailingWrite) {
   GURL blob_url("blob:writeinvalidfile");
   scoped_refptr<webkit_blob::BlobData> blob_data(new webkit_blob::BlobData());
   blob_data->AppendData("It\'ll not be written.");
 
-  scoped_refptr<TestURLRequestContext> url_request_context(
-      new TestURLRequestContext());
-  url_request_context->blob_storage_controller()->AddFinishedBlob(
+  TestURLRequestContext url_request_context;
+  url_request_context.blob_storage_controller()->AddFinishedBlob(
       blob_url, blob_data);
 
   FileSystemOperationInterface* write_operation = operation();
-  write_operation->Write(url_request_context,
+  write_operation->Write(&url_request_context,
                          URLForPath(FilePath(FILE_PATH_LITERAL("nonexist"))),
                          blob_url, 0, RecordWriteCallback());
   write_operation->Cancel(RecordCancelCallback());
   // We use RunAllPendings() instead of Run() here, because we won't dispatch
   // callbacks after Cancel() is issued (so no chance to Quit) nor do we need
   // to run another write cycle.
   MessageLoop::current()->RunAllPending();
 
-  url_request_context->blob_storage_controller()->RemoveBlob(blob_url);
+  url_request_context.blob_storage_controller()->RemoveBlob(blob_url);
 
   // Issued Cancel() before receiving any response from Write(),
   // so nothing should have happen.
   EXPECT_EQ(0, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_ABORT, status());
   EXPECT_EQ(base::PLATFORM_FILE_OK, cancel_status());
   EXPECT_TRUE(complete());
 }
 
 // TODO(ericu,dmikurube): Add more tests for Cancel.
 
 }  // namespace fileapi