Stop refcounting URLRequestContext.

net/url_request/url_request.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
@@ skipping 114 matching lines @@
 void URLRequest::Delegate::OnSSLCertificateError(URLRequest* request,
                                                  const SSLInfo& ssl_info,
                                                  bool is_hsts_ok) {
   request->Cancel();
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // URLRequest
 
 URLRequest::URLRequest(const GURL& url, Delegate* delegate)
-    : url_chain_(1, url),
+    : context_(NULL),
+      url_chain_(1, url),
       method_("GET"),
       load_flags_(LOAD_NORMAL),
       delegate_(delegate),
       is_pending_(false),
       redirect_limit_(kMaxRedirects),
       final_upload_progress_(0),
       priority_(LOWEST),
       identifier_(GenerateURLRequestIdentifier()),
       blocked_on_delegate_(false),
       ALLOW_THIS_IN_INITIALIZER_LIST(before_request_callback_(
@@ skipping 569 matching lines @@
 
   if (!final_upload_progress_)
     final_upload_progress_ = job_->GetUploadProgress();
 
   PrepareToRestart();
   Start();
   return OK;
 }
 
 const URLRequestContext* URLRequest::context() const {
-  return context_.get();
+  return context_;
 }
 
 void URLRequest::set_context(const URLRequestContext* context) {

[eroman, 2012/05/04 04:27:02]

sidecomment: are there any legitimate use cases for changing the context other
than from NULL --> something OR something --> NULL? Seems like a recipe for
problems to do anything else, and certainly should not change after a request
has started. hmm i'll have to think more about this.

   // Update the URLRequest lists in the URLRequestContext.
   if (context_) {
     std::set<const URLRequest*>* url_requests = context_->url_requests();
     CHECK(ContainsKey(*url_requests, this));
     url_requests->erase(this);
   }
 
   if (context) {
     std::set<const URLRequest*>* url_requests = context->url_requests();
     CHECK(!ContainsKey(*url_requests, this));
     url_requests->insert(this);
   }
 
-  scoped_refptr<const URLRequestContext> prev_context = context_;
+  const URLRequestContext* prev_context = context_;
 
   context_ = context;
 
   // If the context this request belongs to has changed, update the tracker.
   if (prev_context != context) {
     int net_error = OK;
     // Log error only on failure, not cancellation, as even successful requests
     // are "cancelled" on destruction.
     if (status_.status() == URLRequestStatus::FAILED)
       net_error = status_.error();
@@ skipping 136 matching lines @@
 
 void URLRequest::SetUnblockedOnDelegate() {
   if (!blocked_on_delegate_)
     return;
   blocked_on_delegate_ = false;
   load_state_param_.clear();
   net_log_.EndEvent(NetLog::TYPE_URL_REQUEST_BLOCKED_ON_DELEGATE, NULL);
 }
 
 }  // namespace net