content/shell/shell_url_request_context_getter.h - Issue 10299002: Stop refcounting URLRequestContext.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/shell/shell_url_request_context_getter.h

Issue 10299002: Stop refcounting URLRequestContext. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More fixes Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/service/net/service_url_request_context.h ('K') | « content/common/net/url_fetcher_impl_unittest.cc ('k') | content/shell/shell_url_request_context_getter.cc » ('j') | content/test/mock_resource_context.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_SHELL_SHELL_URL_REQUEST_CONTEXT_GETTER_H_	5 #ifndef CONTENT_SHELL_SHELL_URL_REQUEST_CONTEXT_GETTER_H_

6 #define CONTENT_SHELL_SHELL_URL_REQUEST_CONTEXT_GETTER_H_	6 #define CONTENT_SHELL_SHELL_URL_REQUEST_CONTEXT_GETTER_H_

7 #pragma once	7 #pragma once

8	8

9 #include "base/compiler_specific.h"	9 #include "base/compiler_specific.h"

10 #include "base/file_path.h"	10 #include "base/file_path.h"

(...skipping 28 matching lines...) Expand all Loading...
39	39

40 protected:	40 protected:

41 virtual ~ShellURLRequestContextGetter();	41 virtual ~ShellURLRequestContextGetter();

42	42

43 private:	43 private:

44 FilePath base_path_;	44 FilePath base_path_;

45 MessageLoop* io_loop_;	45 MessageLoop* io_loop_;

46 MessageLoop* file_loop_;	46 MessageLoop* file_loop_;

47	47

48 scoped_ptr<net::ProxyConfigService> proxy_config_service_;	48 scoped_ptr<net::ProxyConfigService> proxy_config_service_;

49	49 scoped_ptr<net::NetworkDelegate> network_delegate_;

50 scoped_refptr<net::URLRequestContext> url_request_context_;	50 scoped_ptr<net::URLRequestContext> url_request_context_;

51 scoped_ptr<net::URLRequestContextStorage> storage_;	51 scoped_ptr<net::URLRequestContextStorage> storage_;
	eroman 2012/05/04 04:27:02 Feels like the storage should probably outlive url Feels like the storage should probably outlive url_request_context_ in declaration order.
52 scoped_ptr<net::NetworkDelegate> network_delegate_;

53	52

54 DISALLOW_COPY_AND_ASSIGN(ShellURLRequestContextGetter);	53 DISALLOW_COPY_AND_ASSIGN(ShellURLRequestContextGetter);

55 };	54 };

56	55

57 } // namespace content	56 } // namespace content

58	57

59 #endif // CONTENT_SHELL_SHELL_URL_REQUEST_CONTEXT_GETTER_H_	58 #endif // CONTENT_SHELL_SHELL_URL_REQUEST_CONTEXT_GETTER_H_

OLD	NEW