Stop refcounting URLRequestContext.

chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <queue>
 #include <map>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/file_util.h"
@@ skipping 109 matching lines @@
         io_thread_(content::BrowserThread::IO, &message_loop_) {}
 
  protected:
   virtual void SetUp() OVERRIDE {
     event_router_ = new ExtensionEventRouterForwarder();
     enable_referrers_.Init(
         prefs::kEnableReferrers, profile_.GetTestingPrefService(), NULL);
     network_delegate_.reset(new ChromeNetworkDelegate(
         event_router_.get(), NULL, NULL, &profile_,
         CookieSettings::Factory::GetForProfile(&profile_), &enable_referrers_));
-    context_ = new TestURLRequestContext();
+    context_.reset(new TestURLRequestContext());
     context_->set_network_delegate(network_delegate_.get());
   }
 
   MessageLoopForIO message_loop_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread io_thread_;
   TestingProfile profile_;
   TestDelegate delegate_;
   BooleanPrefMember enable_referrers_;
   TestIPCSender ipc_sender_;
   scoped_refptr<ExtensionEventRouterForwarder> event_router_;
   scoped_refptr<ExtensionInfoMap> extension_info_map_;
   scoped_ptr<ChromeNetworkDelegate> network_delegate_;
-  scoped_refptr<TestURLRequestContext> context_;
+  scoped_ptr<TestURLRequestContext> context_;
 };
 
 // Tests that we handle disagreements among extensions about responses to
 // blocking events (redirection) by choosing the response from the
 // most-recently-installed extension.
 TEST_F(ExtensionWebRequestTest, BlockingEventPrecedenceRedirect) {
   std::string extension1_id("1");
   std::string extension2_id("2");
   ExtensionWebRequestEventRouter::RequestFilter filter;
   const std::string kEventName(keys::kOnBeforeRequest);
   base::WeakPtrFactory<TestIPCSender> ipc_sender_factory(&ipc_sender_);
   ExtensionWebRequestEventRouter::GetInstance()->AddEventListener(
       &profile_, extension1_id, extension1_id, kEventName, kEventName + "/1",
       filter, ExtensionWebRequestEventRouter::ExtraInfoSpec::BLOCKING,
       ipc_sender_factory.GetWeakPtr());
   ExtensionWebRequestEventRouter::GetInstance()->AddEventListener(
       &profile_, extension2_id, extension2_id, kEventName, kEventName + "/2",
       filter, ExtensionWebRequestEventRouter::ExtraInfoSpec::BLOCKING,
       ipc_sender_factory.GetWeakPtr());
 
   GURL redirect_url("about:redirected");
   GURL not_chosen_redirect_url("about:not_chosen");
 
   net::URLRequest request(GURL("about:blank"), &delegate_);
-  request.set_context(context_);
+  request.set_context(context_.get());
   {
     // onBeforeRequest will be dispatched twice initially. The second response -
     // the redirect - should win, since it has a later |install_time|. The
     // redirect will dispatch another pair of onBeforeRequest. There, the first
     // response should win (later |install_time|).
     ExtensionWebRequestEventRouter::EventResponse* response = NULL;
 
     // Extension1 response. Arrives first, but ignored due to install_time.
     response = new ExtensionWebRequestEventRouter::EventResponse(
         extension1_id, base::Time::FromDoubleT(1));
@@ skipping 34 matching lines @@
     EXPECT_TRUE(!request.is_pending());
     EXPECT_EQ(net::URLRequestStatus::SUCCESS, request.status().status());
     EXPECT_EQ(0, request.status().error());
     EXPECT_EQ(redirect_url, request.url());
     EXPECT_EQ(2U, request.url_chain().size());
     EXPECT_EQ(0U, ipc_sender_.GetNumTasks());
   }
 
   // Now test the same thing but the extensions answer in reverse order.
   net::URLRequest request2(GURL("about:blank"), &delegate_);
-  request2.set_context(context_);
+  request2.set_context(context_.get());
   {
     ExtensionWebRequestEventRouter::EventResponse* response = NULL;
 
     // Extension2 response. Arrives first, and chosen because of install_time.
     response = new ExtensionWebRequestEventRouter::EventResponse(
         extension2_id, base::Time::FromDoubleT(2));
     response->new_url = redirect_url;
     ipc_sender_.PushTask(
         base::Bind(&EventHandledOnIOThread,
             &profile_, extension2_id, kEventName, kEventName + "/2",
@@ skipping 53 matching lines @@
     &profile_, extension1_id, extension1_id, kEventName, kEventName + "/1",
     filter, ExtensionWebRequestEventRouter::ExtraInfoSpec::BLOCKING,
     ipc_sender_factory.GetWeakPtr());
   ExtensionWebRequestEventRouter::GetInstance()->AddEventListener(
     &profile_, extension2_id, extension2_id, kEventName, kEventName + "/2",
     filter, ExtensionWebRequestEventRouter::ExtraInfoSpec::BLOCKING,
     ipc_sender_factory.GetWeakPtr());
 
   GURL request_url("about:blank");
   net::URLRequest request(request_url, &delegate_);
-  request.set_context(context_);
+  request.set_context(context_.get());
 
   // onBeforeRequest will be dispatched twice. The second response -
   // the redirect - would win, since it has a later |install_time|, but
   // the first response takes precedence because cancel >> redirect.
   GURL redirect_url("about:redirected");
   ExtensionWebRequestEventRouter::EventResponse* response = NULL;
 
   // Extension1 response. Arrives first, would be ignored in principle due to
   // install_time but "cancel" always wins.
   response = new ExtensionWebRequestEventRouter::EventResponse(
@@ skipping 47 matching lines @@
   ExtensionWebRequestEventRouter::GetInstance()->AddEventListener(
     &profile_, extension_id, extension_id, kEventName, kEventName + "/1",
     filter, ExtensionWebRequestEventRouter::ExtraInfoSpec::BLOCKING,
     ipc_sender_factory.GetWeakPtr());
   ExtensionWebRequestEventRouter::GetInstance()->AddEventListener(
     &profile_, extension_id, extension_id, kEventName2, kEventName2 + "/1",
     filter, 0, ipc_sender_factory.GetWeakPtr());
 
   GURL request_url("about:blank");
   net::URLRequest request(request_url, &delegate_);
-  request.set_context(context_);
+  request.set_context(context_.get());
 
   ExtensionWebRequestEventRouter::EventResponse* response = NULL;
 
   // Extension response for the OnBeforeRequest handler. This should not be
   // processed because request is canceled before the handler responds.
   response = new ExtensionWebRequestEventRouter::EventResponse(
       extension_id, base::Time::FromDoubleT(1));
   GURL redirect_url("about:redirected");
   response->new_url = redirect_url;
   ipc_sender_.PushTask(
@@ skipping 60 matching lines @@
         io_thread_(content::BrowserThread::IO, &message_loop_) {}
 
  protected:
   virtual void SetUp() {
     event_router_ = new ExtensionEventRouterForwarder();
     enable_referrers_.Init(
         prefs::kEnableReferrers, profile_.GetTestingPrefService(), NULL);
     network_delegate_.reset(new ChromeNetworkDelegate(
         event_router_.get(), NULL, NULL, &profile_,
         CookieSettings::Factory::GetForProfile(&profile_), &enable_referrers_));
-    context_ = new TestURLRequestContext();
+    context_.reset(new TestURLRequestContext());
     context_->set_network_delegate(network_delegate_.get());
   }
 
   MessageLoopForIO message_loop_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread io_thread_;
   TestingProfile profile_;
   TestDelegate delegate_;
   BooleanPrefMember enable_referrers_;
   TestIPCSender ipc_sender_;
   scoped_refptr<ExtensionEventRouterForwarder> event_router_;
   scoped_refptr<ExtensionInfoMap> extension_info_map_;
   scoped_ptr<ChromeNetworkDelegate> network_delegate_;
-  scoped_refptr<TestURLRequestContext> context_;
+  scoped_ptr<TestURLRequestContext> context_;
 };
 
 TEST_P(ExtensionWebRequestHeaderModificationTest, TestModifications) {
   std::string extension1_id("1");
   std::string extension2_id("2");
   std::string extension3_id("3");
   ExtensionWebRequestEventRouter::RequestFilter filter;
   const std::string kEventName(keys::kOnBeforeSendHeaders);
   base::WeakPtrFactory<TestIPCSender> ipc_sender_factory(&ipc_sender_);
 
@@ skipping 10 matching lines @@
 
   // Install one extension that observes the final headers.
   ExtensionWebRequestEventRouter::GetInstance()->AddEventListener(
       &profile_, extension3_id, extension3_id, keys::kOnSendHeaders,
       std::string(keys::kOnSendHeaders) + "/3", filter,
       ExtensionWebRequestEventRouter::ExtraInfoSpec::REQUEST_HEADERS,
       ipc_sender_factory.GetWeakPtr());
 
   GURL request_url("http://doesnotexist/does_not_exist.html");
   net::URLRequest request(request_url, &delegate_);
-  request.set_context(context_);
+  request.set_context(context_.get());
 
   // Initialize headers available before extensions are notified of the
   // onBeforeSendHeaders event.
   HeaderModificationTest test = GetParam();
   net::HttpRequestHeaders before_headers;
   for (int i = 0; i < test.before_size; ++i)
     before_headers.SetHeader(test.before[i].name, test.before[i].value);
   request.SetExtraRequestHeaders(before_headers);
 
   // Gather the modifications to the headers for the respective extensions.
@@ skipping 997 matching lines @@
   };
   for (size_t i = 0; i < arraysize(sensitive_urls); ++i) {
     EXPECT_TRUE(helpers::HideRequestForURL(GURL(sensitive_urls[i])))
         << sensitive_urls[i];
   }
   for (size_t i = 0; i < arraysize(non_sensitive_urls); ++i) {
     EXPECT_FALSE(helpers::HideRequestForURL(GURL(non_sensitive_urls[i])))
         << non_sensitive_urls[i];
   }
 }