Issue 10298012: [protector] Disable the UI by default, flip --no-protector to --protector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10298012: [protector] Disable the UI by default, flip --no-protector to --protector. (Closed)

Created:
8 years, 7 months ago by Ivan Korotkov

Modified:
8 years, 7 months ago

Reviewers:
whywhat, sky, Nirnimesh

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[protector] Disable the UI by default, flip --no-protector to --protector. BUG=None TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135219

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -25 lines)			Patch
M	chrome/browser/protector/protector_service_browsertest.cc	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/protector/protector_utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/functional/protector.py	View	2 chunks	+17 lines, -15 lines	0 comments	Download

Total messages: 7 (0 generated)

Ivan Korotkov

PTAL avayvod: everything else nirnimesh: functional/

8 years, 7 months ago (2012-05-03 14:00:53 UTC) #1

Ivan Korotkov

Hi Scott, can you take a look please? This is similar to what you've reviewed ...

8 years, 7 months ago (2012-05-03 16:23:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10298012/1

8 years, 7 months ago (2012-05-03 20:02:32 UTC) #6

Change committed as 135219