Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: chrome/browser/background/background_mode_manager.h

Issue 10298002: No longer start BG mode until a BackgroundContents is loaded (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed tests. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_mode_manager.h
diff --git a/chrome/browser/background/background_mode_manager.h b/chrome/browser/background/background_mode_manager.h
index 633c92bad4a5cd12bb5fd2044c2ceb4391e63fe2..0402e7921f88908095bf69ec4347c80967edfbc5 100644
--- a/chrome/browser/background/background_mode_manager.h
+++ b/chrome/browser/background/background_mode_manager.h
@@ -45,7 +45,6 @@ class BackgroundModeManager
: public content::NotificationObserver,
public BackgroundApplicationListModel::Observer,
public ProfileInfoCacheObserver,
- public ProfileKeyedService,
public ui::SimpleMenuModel::Delegate {
public:
BackgroundModeManager(CommandLine* command_line,
@@ -59,12 +58,16 @@ class BackgroundModeManager
static void LaunchBackgroundApplication(Profile* profile,
const Extension* extension);
+ // Returns true if background mode is active. Used only by tests.
+ bool IsBackgroundModeActiveForTest();
+
// For testing purposes.
int NumberOfBackgroundModeData();
private:
- friend class TestBackgroundModeManager;
+ friend class AppBackgroundPageApiTest;
Mihai Parparita -not on Chrome 2012/05/03 00:54:11 Given this friend declaration, does IsBackgroundMo
Andrew T Wilson (Slow) 2012/05/03 07:42:56 Agreed, it can be private.
friend class BackgroundModeManagerTest;
+ friend class TestBackgroundModeManager;
FRIEND_TEST_ALL_PREFIXES(BackgroundModeManagerTest,
BackgroundAppLoadUnload);
FRIEND_TEST_ALL_PREFIXES(BackgroundModeManagerTest,

Powered by Google App Engine
This is Rietveld 408576698