Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: chrome/browser/background/background_mode_manager.cc

Issue 10298002: No longer start BG mode until a BackgroundContents is loaded (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed tests. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_mode_manager.cc
diff --git a/chrome/browser/background/background_mode_manager.cc b/chrome/browser/background/background_mode_manager.cc
index e21c5728641fa291946e630cfcff80c363830eac..06de11a606d98e0b4bb1c43602f7fc3754cc7aa8 100644
--- a/chrome/browser/background/background_mode_manager.cc
+++ b/chrome/browser/background/background_mode_manager.cc
@@ -263,6 +263,10 @@ void BackgroundModeManager::LaunchBackgroundApplication(
NEW_FOREGROUND_TAB);
}
+bool BackgroundModeManager::IsBackgroundModeActiveForTest() {
+ return in_background_mode_;
+}
+
int BackgroundModeManager::NumberOfBackgroundModeData() {
return background_mode_data_.size();
}
@@ -290,10 +294,11 @@ void BackgroundModeManager::Observe(
case chrome::NOTIFICATION_EXTENSION_LOADED: {
Extension* extension = content::Details<Extension>(details).ptr();
- if (BackgroundApplicationListModel::IsBackgroundApp(*extension)) {
+ Profile* profile = content::Source<Profile>(source).ptr();
+ if (BackgroundApplicationListModel::IsBackgroundApp(
+ *extension, profile)) {
// Extensions loaded after the ExtensionsService is ready should be
// treated as new installs.
- Profile* profile = content::Source<Profile>(source).ptr();
if (profile->GetExtensionService()->is_ready())
OnBackgroundAppInstalled(extension);
}

Powered by Google App Engine
This is Rietveld 408576698