Issue 10293002: gdata: Properly remove file watchers on gdata.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10293002: gdata: Properly remove file watchers on gdata. (Closed)

Created:
8 years, 7 months ago by hshi

Modified:
8 years, 7 months ago

Reviewers:
satorux1, zel

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

gdata: Properly remove file watchers on gdata. Apply path tweaking logic for remote resources in FileBrowserEventRouter::RemoveFileWatch to match that in AddFileWatch, otherwise we would fail to locate the watch_path in the map "file_watchers_" and to remove the file watcher. BUG=chromium-os:29720 TEST=Tested locally with debug chrome build on Linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134837

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/browser/chromeos/extensions/file_browser_event_router.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@google.com/10293002/1

8 years, 7 months ago (2012-05-01 23:27:09 UTC) #4

Change committed as 134837

Expand Messages | Collapse Messages