remoting/client/plugin/pepper_packet_socket_factory.cc - Issue 10284008: Switch client to Pepper UDP API instead of Transport API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/plugin/pepper_packet_socket_factory.cc

Issue 10284008: Switch client to Pepper UDP API instead of Transport API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/plugin/pepper_packet_socket_factory.cc

diff --git a/remoting/client/plugin/pepper_packet_socket_factory.cc b/remoting/client/plugin/pepper_packet_socket_factory.cc

index 461571d295543e0dfc357ffb506ed658863b4767..f83180ba8b35747b98f1d86194d174147e3176b6 100644

--- a/remoting/client/plugin/pepper_packet_socket_factory.cc

+++ b/remoting/client/plugin/pepper_packet_socket_factory.cc

@@ -197,7 +197,11 @@ int UdpPacketSocket::Send(const void* data, size_t data_size) {

int UdpPacketSocket::SendTo(const void* data,

size_t data_size,

const talk_base::SocketAddress& address) {

- DCHECK_EQ(state_, STATE_BOUND);

+ if (state_ != STATE_BOUND) {

+ // TODO(sergeyu): StunPort may try to send stun request before we

+ // are bound. Fix that problem and change this to DCHECK.

+ return EINVAL;

+ }

if (error_ != 0) {

return error_;